Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug

[Love Nystrom]

Hi Eric,

Sounds like you got it licked, the right way.
Good job !

Best Regards
L.

2011/5/6 [e-mail]
> From: Eric Kohl [e-mail]
> To: ReactOS Development List [e-mail]
> Date: Thu, 05 May 2011 22:41:24 +0200
> Subject: Re: [ros-dev] [EVENTVWR/EVENTLOG] Fix a double off-by-one bug
> Hi Love,
>
> I just committed a fix for the calculation of the available number of event
> records. It addresses the issues you mentioned.
>
> And this is how it works:
> When a new log file is created, the first (or oldest) record gets the
> record number 1. With each new event record the record number is incremented
> by 1. To get the number of records in the log file we need to subtract the
> OldestRecordNumber from the CurrentRecordNumber. If the log file is empty
> the OldestRecordNumber will be 0. In this case we will return 0 for the
> number of event records.
>
> Now we call clear a filled log file and fill it with new records. The
> oldest record will not be record number 1 but we can still return the true
> number of records in the log file.
>
> Regards
> Eric