FW: [ros-bugs] [Bug 644] directional keys problem with Explorer

[Gabriel ilardi]

Hi devs,

I don't think this patch should be refused, what about "Shell32 improvements" in: http://www.reactos.org/en/newsletter_34.html?
And all the commits made recently by johannes (also in shlview.c)? After almost a year we close the bug saying it's not our code?
WBR
Gabriel ilardi.
> Date: Fri, 9 May 2008 18:13:49 +0200> From: [e-mail]> To: [e-mail]> Subject: [ros-bugs] [Bug 644] directional keys problem with Explorer> > http://www.reactos.org/bugzilla/show_bug.cgi?id=644%3E > > amine48rz [e-mail] changed:> > What |Removed |Added> ----------------------------------------------------------------------------> Status|NEW |ASSIGNED> Status|ASSIGNED |NEW> CC| |[e-mail]> AssignedTo|[e-mail] |johannes.anderwald@student.t> | |ugraz.at> > w3seek [e-mail] changed:> > What |Removed |Added> ----------------------------------------------------------------------------> CC| |[e-mail]> Status|NEW |RESOLVED> Resolution| |WONTFIX> > > > > --- Comment #3 from w3seek [e-mail] 2008-05-09 18:13:48 CET ---> (In reply to comment #2)> > Created an attachment (id=1341)> --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1341) [details]> > LISTVIEW_GetNextItem Patch> > Here's a new patch for which i rewrote the LISTVIEW_GetNextItem routine, so> > that the ListView itself is aware of whether LVS_ALIGNTOP or LVS_ALIGNLEFT is> > set and returns the correct next item.> > But I still like the other patch just because I dislike scrolling horizontal in> > a list :).> > This patch should not be accepted for ReactOS. This is code shared with WINE> and needs to be submitted to winehq.> > > -- > Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email%3E ------- You are receiving this mail because: -------> You are the QA contact for the bug.> _______________________________________________> Ros-bugs mailing list> [e-mail]> http://www.reactos.org/mailman/listinfo/ros-bugs

_________________________________________________________________
Crea il tuo blog su Spaces, condividi le tue esperienze con il mondo! 
http://home.services.spaces.live.com/

[Colin Finck]

Shell32 was forked long time ago, so it's true that we can apply patches to
it on our own now.
But w3seek closed the bug, because of the patch against "comctl32", which is
still synchronized with Wine.

The question is now: Which one of these patches is the correct or the better
one?
At first glance, the shell32 patch looks like a hack.

Best regards,

Colin

_____

From: [e-mail] [mailto:[e-mail]] On
Behalf Of Gabriel ilardi
Sent: Friday, May 09, 2008 7:27 PM
To: ros-dev
Subject: [ros-dev] FW: [ros-bugs] [Bug 644] directional keys problem
withExplorer

Hi devs,

I don't think this patch should be refused, what about "Shell32
improvements" in: http://www.reactos.org/en/newsletter_34.html?
And all the commits made recently by johannes (also in shlview.c)? After
almost a year we close the bug saying it's not our code?

WBR
Gabriel ilardi.

_____
> Date: Fri, 9 May 2008 18:13:49 +0200
> From: [e-mail]
> To: [e-mail]
> Subject: [ros-bugs] [Bug 644] directional keys problem with Explorer
>
> http://www.reactos.org/bugzilla/show_bug.cgi?id=644
>
> amine48rz [e-mail] changed:
>
> What |Removed |Added

----------------------------------------------------------------------------
> Status|NEW |ASSIGNED
> Status|ASSIGNED |NEW
> CC| |[e-mail]
> AssignedTo|[e-mail] |johannes.anderwald@student.t
> | |ugraz.at
>
> w3seek [e-mail] changed:
>
> What |Removed |Added

----------------------------------------------------------------------------
> CC| |[e-mail]
> Status|NEW |RESOLVED
> Resolution| |WONTFIX
>
> --- Comment #3 from w3seek [e-mail] 2008-05-09 18:13:48 CET

---
> (In reply to comment #2)
> > Created an attachment (id=1341)
>
> --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1341) [details]
> > LISTVIEW_GetNextItem Patch
> > Here's a new patch for which i rewrote the LISTVIEW_GetNextItem routine,

so
> > that the ListView itself is aware of whether LVS_ALIGNTOP or

LVS_ALIGNLEFT is
> > set and returns the correct next item.
> > But I still like the other patch just because I dislike scrolling

horizontal in
> > a list :).
>
> This patch should not be accepted for ReactOS. This is code shared with

WINE
> and needs to be submitted to winehq.
>
> -- 
> Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the QA contact for the bug.
> _______________________________________________
> Ros-bugs mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-bugs

_____

Windows Live Messenger Non  http://www.messenger.it frenare la tua voglia
di comunicare, prova Messenger!