Re: [ros-diffs] [ion] 13305: Dynamic 3GB support, part 1. Only multiboot.S remains to be changed, all other parts of the Kernel now used KERNEL_BASE based on the command-line (Please don't use /3gb if you don't compile 3GB)

[Filip Navara]

ion(a)svn.reactos.com wrote:

>  +  /* Gotta check 3GB setting right *here* before we
> use KERNEL_BASE! */
> +  if (!_strnicmp(KeLoaderCommandLine, "3GB", 3)) {
>  
This looks obviously wrong, you're comparing the beginning of kernel 
command line with "3GB". It would make more sense to actually check if 
the "3GB" is somewhere in the command line (even though that's not 
correct too)...

- Filip

[Alex Ionescu]

Filip Navara wrote:

>   ion(a)svn.reactos.com wrote:
>
> >   +  /* Gotta check 3GB setting right *here* before
> > we use KERNEL_BASE! */
> >  +  if (!_strnicmp(KeLoaderCommandLine, "3GB", 3)) {
> >  
>  This looks obviously wrong, you're comparing the beginning of kernel 
>  command line with "3GB". It would make more sense to actually check if 
>  the "3GB" is somewhere in the command line (even though that's not 
>  correct too)...
>
>  - Filip 
Hi,

You're right... I don't even remember writing that code... anyways it 
will be removed today.

Best regards,
Alex Ionescu