file copy during install

[Hartmut Birr]

Hi,

during install, I see the following two lines:

(lib\setupapi\queue.c:1441) copy error 2 L"C:\\ReactOS\\inf\\ne2000.sys" ->
L"C:\\ReactOS\\System32\\drivers\\ne2000.sys"
(lib\setupapi\queue.c:1441) copy error 2 L"C:\\ReactOS\\inf\\pci.sys" ->
L"C:\\ReactOS\\System32\\drivers\\pci.sys"

Why does ROS try to copy drivers from the inf directory?

- Hartmut

[Hervé Poussineau]

Hello, 

De : ros-dev-bounces(a)reactos.org [mailto:[e-mail]] De la
part de Hartmut Birr
>  during install, I see the following two lines:
>
> (lib\setupapi\queue.c:1441) copy error 2 L"C:\\ReactOS\\inf\\ne2000.sys" ->
L"C:\\ReactOS\\System32\\drivers\\ne2000.sys"
>  (lib\setupapi\queue.c:1441) copy error 2
> L"C:\\ReactOS\\inf\\pci.sys" ->
L"C:\\ReactOS\\System32\\drivers\\pci.sys"
>  
> Why does ROS try to copy drivers from the inf directory? 
Setupapi.dll is not perfect at the moment.
That's normal it first tries to find files specified in .inf file in the
same directory as the .inf file (here, C:\ReactOS\inf).

If the file is not found, setupapi is calling the default callback routine
in SetupDefaultQueueCallbackA/W, with notification ==
SPFILENOTIFY_COPYERROR.
At the moment, the default callback routine only logs the error and tell to
skip the missing file (see lib/setupapi/queue.c:1375-1378 and
lib/setupapi/queue.c:1440-1443). Instead of this, it would be good to ask
the user where to find the file, and so he may provide a cdrom or another
location for the file. Acceptable return values for this function are
FILEOP_ABORT, FILEOP_NEWPATH and FILEOP_SKIP.
Feel free to implement it if you want.

Regards,

Hervé