fix for regedit

[Christian Koinig]

This fixes the problem with regedit (regedit freezes after opening a
child window).

Regards
Christian

------------------------------------------------------
Index: framewnd.c
===================================================================
RCS file: /CVS/ReactOS/reactos/subsys/system/regedit/framewnd.c,v
retrieving revision 1.11
diff -u -p -r1.11 framewnd.c
--- framewnd.c	11 Oct 2004 21:08:05 -0000	1.11
+++ framewnd.c	18 Nov 2004 21:56:01 -0000
@@ -670,8 +670,10 @@ FrameWndProc(HWND hWnd, UINT message, WP
         OnMenuSelect(hWnd, LOWORD(wParam), HIWORD(wParam), (HMENU)lParam);
         break;
     case WM_ACTIVATE:
-        if (LOWORD(hWnd))
-          SetFocus(g_pChildWnd->hWnd);
+        // I don't know what this is supposed to do (except for
creating an infinite "setfocus loop").
+        // If someone ever figures it out put it back in plz.
+        //if (LOWORD(hWnd))
+        //  SetFocus(g_pChildWnd->hWnd);
         break;
     case WM_DESTROY:
         WinHelp(hWnd, _T("regedit"), HELP_QUIT, 0);

------------------------------------------------------

[Steven Edwards]

Hello,

--- Christian Koinig [e-mail] wrote:
> This fixes the problem with regedit (regedit freezes after opening a
> child window).

Does this freeze happen on Windows too? If so then the bug is in
ReactOS and should be fixed there rather than in the application.

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - Get yours free! 
http://my.yahoo.com

Hi
It is not reactos regedit apps fault.
it works fine in windows.

it is some where in reactos

Citerar Steven Edwards [e-mail]:
> Hello,
>
> --- Christian Koinig [e-mail] wrote:
> > This fixes the problem with regedit (regedit freezes after opening a
> > child window).
>
> Does this freeze happen on Windows too? If so then the bug is in
> ReactOS and should be fixed there rather than in the application.
>
> Thanks
> Steven
>
> Do you Yahoo!?
> The all-new My Yahoo! - Get yours free!
> http://my.yahoo.com
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

[Thomas Weidenmueller]

Christian Koinig wrote:
> This fixes the problem with regedit (regedit freezes after opening a
> child window).
>
> Regards
> Christian

The attached patch should not be applied. regedit works fine in windows 
and we should rather fix user32/win32k than regedit in my opinion.

Best Regards
Thomas

"Christian Koinig" [e-mail] wrote:
> This fixes the problem with regedit (regedit freezes after opening a
> child window).

This patch makes it impossible to navigate the registry using the keyboard
only.

Regards,
Eric