RFC: Change Rapps 'Size' field

[Mark Jansen]

Hello,

I'd like to propose a change for the 'Size' field:
Currently this is a localized, pre-formatted field.
By changing this to the actual size in bytes:
- We can use StrFormatByteSizeW to format it locale dependent (without 
the need to manually translate it)
- We can use this value to display the progress bar, in case the 
download itself does not provide this value (for example, web.archive 
does not provide this).

For backwards compatibility we should probably add this as another 
field, so that the 'old' rapps can still read the 'Size' field.

Regards,

Mark

[Hermès BÉLUSCA-MAÏTO]

What 'size' field are you exactly talking about?

>   -----Message d'origine-----
>  De : Ros-dev [mailto:[e-mail]] De la part de Mark Jansen
>  Envoyé : jeudi 8 février 2018 20:43
>  À : ros-dev(a)reactos.org
>  Objet : [ros-dev] RFC: Change Rapps 'Size' field
>  
>  Hello,
>  
>  I'd like to propose a change for the 'Size' field:
>  Currently this is a localized, pre-formatted field.
>  By changing this to the actual size in bytes:
>  - We can use StrFormatByteSizeW to format it locale dependent (without the
>  need to manually translate it)
>  - We can use this value to display the progress bar, in case the download itself
>  does not provide this value (for example, web.archive does not provide this).
>  
>  For backwards compatibility we should probably add this as another field, so
>  that the 'old' rapps can still read the 'Size' field.
>  
>  Regards,
>  
>  Mark
>  
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[David Quintana (gigaherz)]

https://github.com/reactos/rapps-db/blob/master/7zip.txt#L6

On 8 February 2018 at 21:00, Hermès BÉLUSCA-MAÏTO <hermes.belusca(a)sfr.fr>
wrote:

>   What 'size' field are you exactly talking
> about?
>
> >   -----Message d'origine-----
> >  De : Ros-dev [mailto:[e-mail]] De la part de Mark 
>  Jansen
> >   Envoyé : jeudi 8 février 2018 20:43
> >  À : ros-dev(a)reactos.org
> >  Objet : [ros-dev] RFC: Change Rapps 'Size' field
> >
> >  Hello,
> >
> >  I'd like to propose a change for the 'Size' field:
> >  Currently this is a localized, pre-formatted field.
> >  By changing this to the actual size in bytes:
> >  - We can use StrFormatByteSizeW to format it locale dependent (without 
>  the
> >   need to manually translate it)
> >  - We can use this value to display the progress bar, in case the 
>  download itself
> >   does not provide this value (for example,
> > web.archive does not provide 
>  this).
> >  
> >  For backwards compatibility we should probably add this as another 
>  field, so
> >   that the 'old' rapps can still read the
> > 'Size' field.
> >
> >  Regards,
> >
> >  Mark
> >
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev 
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Hermès BÉLUSCA-MAÏTO]

Two possibilities :

-          Either have : « Size = 1.345.123 » with no units, it’s in bytes, otherwise it
is a string to be displayed. I wonder if that already breaks backwards compatibility with
old versions of rapps… But then these old versions of rapps may or may not be able to
connect to the new web service we are preparing for the databases? (in which case we don’t
have to care too much about them)

-          Or just use some “ SizeInBytes = 1.345.123 ” field. It’s clear, and you just
read that value and use the shell function you pointed in your previous mail to format it
in MB or whatever.

 

Hermès

 

De : Ros-dev [mailto:[e-mail]] De la part de David Quintana (gigaherz)
Envoyé : jeudi 8 février 2018 21:03
À : ReactOS Development List
Objet : Re: [ros-dev] RFC: Change Rapps 'Size' field

 

https://github.com/reactos/rapps-db/blob/master/7zip.txt#L6

 

On 8 February 2018 at 21:00, Hermès BÉLUSCA-MAÏTO <hermes.belusca(a)sfr.fr> wrote:

What 'size' field are you exactly talking about?

>   -----Message d'origine-----
>  De : Ros-dev [mailto:[e-mail]] De la part de Mark Jansen
>  Envoyé : jeudi 8 février 2018 20:43
>  À : ros-dev(a)reactos.org
>  Objet : [ros-dev] RFC: Change Rapps 'Size' field 
>  
>  Hello,
>
>  I'd like to propose a change for the 'Size' field:
>  Currently this is a localized, pre-formatted field.
>  By changing this to the actual size in bytes:
>  - We can use StrFormatByteSizeW to format it locale dependent (without the
>  need to manually translate it)
>  - We can use this value to display the progress bar, in case the download itself
>  does not provide this value (for example, web.archive does not provide this).
>
>  For backwards compatibility we should probably add this as another field, so
>  that the 'old' rapps can still read the 'Size' field.
>
>  Regards,
>
>  Mark
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev 

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev