Re: [ros-dev] [ros-diffs] [reactos] 01/01: [NETAPI32] Implement DsDeregisterDnsHostRecordsA

[Thomas Faber]

Hey Eric,

On 2019-08-24 22:58, Eric Kohl wrote:
>   diff --git a/dll/win32/netapi32/netlogon.c
> b/dll/win32/netapi32/netlogon.c
>  index 2c068dc176b..73a0324f0fa 100644
>  --- a/dll/win32/netapi32/netlogon.c
>  +++ b/dll/win32/netapi32/netlogon.c
>  @@ -313,10 +313,58 @@ DsDeregisterDnsHostRecordsA(
>        _In_opt_ GUID *DsaGuid,
>        _In_ LPSTR DnsHostName)
>    { 
[...]
>   +
>  +    if (DnsDomainName != NULL)
>  +    {
>  +        pDnsDomainNameW = NetpAllocWStrFromAnsiStr((PSTR)DnsDomainName);
>  +        if (pDnsDomainNameW == NULL)
>  +        {
>  +            status = ERROR_NOT_ENOUGH_MEMORY;
>  +            goto done;
>  +        }
>  +    }
>  +
>  +    pDnsHostNameW = NetpAllocWStrFromAnsiStr((PSTR)DnsDomainName); 

UserNT points out that you probably meant DnsHostName here rather than DnsDomainName.


>   +    if (pDnsHostNameW == NULL)
>  +    {
>  +        status = ERROR_NOT_ENOUGH_MEMORY;
>  +        goto done;
>  +    }
>  + 
Best,
Thomas

[Eric Kohl]

Hello Thomas,

thanks a lot for the hint! I'll fix it in the next commit.

Best regards,
Eric

Am 25.08.2019 um 07:58 schrieb Thomas Faber:
>   Hey Eric,
>  
>  On 2019-08-24 22:58, Eric Kohl wrote:
> >   diff --git a/dll/win32/netapi32/netlogon.c
> > b/dll/win32/netapi32/netlogon.c
> >  index 2c068dc176b..73a0324f0fa 100644
> >  --- a/dll/win32/netapi32/netlogon.c
> >  +++ b/dll/win32/netapi32/netlogon.c
> >  @@ -313,10 +313,58 @@ DsDeregisterDnsHostRecordsA(
> >        _In_opt_ GUID *DsaGuid,
> >        _In_ LPSTR DnsHostName)
> >    { 
>  [...]
> >   +
> >  +    if (DnsDomainName != NULL)
> >  +    {
> >  +        pDnsDomainNameW = NetpAllocWStrFromAnsiStr((PSTR)DnsDomainName);
> >  +        if (pDnsDomainNameW == NULL)
> >  +        {
> >  +            status = ERROR_NOT_ENOUGH_MEMORY;
> >  +            goto done;
> >  +        }
> >  +    }
> >  +
> >  +    pDnsHostNameW = NetpAllocWStrFromAnsiStr((PSTR)DnsDomainName); 
>  
>  
>  UserNT points out that you probably meant DnsHostName here rather than DnsDomainName.
>  
>  
> >   +    if (pDnsHostNameW == NULL)
> >  +    {
> >  +        status = ERROR_NOT_ENOUGH_MEMORY;
> >  +        goto done;
> >  +    }
> >  + 
>  
>  Best,
>  Thomas
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://reactos.org/mailman/listinfo/ros-dev
>