[ros-diffs] [gadamopoulos] 66454: [USER32_WINETEST] and [ros-diffs] [gadamopoulos] 66457: [USER32] - button.c: Use NtUserAlterWindowStyle

[James Tabor]

Hi!

The message testing, LOL just made more work for Amine...

Okay AlterWindowStyle, could it be better to place it in WIN_SetStyle as a
wrapper, maybe? WIN_SetStyle is just glue code for ReactOS.

James

[Giannis Adamopoulos]

Hi! AFAIK Amine doesn't sync this file because we have already too many changes in it. As for my changes I don't see how it made syncing harder; I changed lines that are already our code in this file. As for WIN_SetStyle, it is a function in wine that has the same behavior with NtUserAlterWindowStyle (change the style without sending messages). I like the idea to keep WIN_SetStyle however this won't improve the situation a lot since we have already added large chunks of code there...

ReactOS Development List [e-mail] wrote on Thu, February 26th, 2015, 12:34 AM:
> Hi!
>
> The message testing, LOL just made more work for Amine...
>
> Okay AlterWindowStyle, could it be better to place it in WIN_SetStyle as a
> wrapper, maybe? WIN_SetStyle is just glue code for ReactOS.
>
> James
> _______________________________________________
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev