RE: [ros-svn] [ekohl] 20496: - Service list entries use a pointer to agroup list entry instead of the goup name.

[Ge van Geldorp]

>   From: ekohl(a)svn.reactos.org
>  
>  - Service list entries use a pointer to a group list entry 
>  instead of the goup name.
>  - New group list entries are created in the 
>  unknown-group-list for services of unknown groups. 
I'm seeing some crashes now because the lpGroup->lpService pointer is NULL.
Patch below seems to fix it, but I have no idea if it's the correct fix.

GvG

Index: subsys/system/services/rpcserver.c
===================================================================
--- subsys/system/services/rpcserver.c  (revision 20508)
+++ subsys/system/services/rpcserver.c  (working copy)
@@ -927,7 +927,7 @@

     if (lpdwTagId != NULL)
     {
-        dwError = ScmAssignNewTag(lpService->lpGroup->lpGroupName,
+        dwError = ScmAssignNewTag(lpLoadOrderGroup,
                                   &lpService->dwTag);
         if (dwError != ERROR_SUCCESS)
             goto done;
@@ -1161,7 +1161,7 @@

     if (lpdwTagId != NULL)
     {
-        dwError = ScmAssignNewTag(lpService->lpGroup->lpGroupName,
+        dwError = ScmAssignNewTag(lpLoadOrderGroup,
                                   &lpService->dwTag);
         if (dwError != ERROR_SUCCESS)
             goto done;

[Eric Kohl]

Ge van Geldorp wrote:
>   I'm seeing some crashes now because the
> lpGroup->lpService pointer is NULL.
>  Patch below seems to fix it, but I have no idea if it's the correct fix.
>  
>  GvG 
This is some leftover from the changes to the group list. ScmAssignTagId 
has got a more useful prototype and the group pointer is now assigned 
_before_ ScmAssignTagId might access it.


Eric