Re: [ros-dev] [ros-diffs] 03/03: [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.

[Pierre Schweitzer]

I'm not sure I understand this commit, nor the PR that was merged before.
This is a synced module, for a Vista+ export... What's the point of this?
It would have been better to sync with Wine and have this patch upstream.

Le 18/11/2018 à 21:03, Hermès Bélusca-Maïto a écrit :
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2d320f5a8daf4627458e81...
>
> commit 2d320f5a8daf4627458e81f0ffd51bdd8f60d120
> Author:     Hermès Bélusca-Maïto [e-mail]
> AuthorDate: Sun Nov 18 21:05:32 2018 +0100
> Commit:     Hermès Bélusca-Maïto [e-mail]
> CommitDate: Sun Nov 18 21:06:22 2018 +0100
> [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.
>
> dll/win32/ole32/ole32.spec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dll/win32/ole32/ole32.spec b/dll/win32/ole32/ole32.spec
> index d4ed1163d4..97667918e9 100644
> --- a/dll/win32/ole32/ole32.spec
> +++ b/dll/win32/ole32/ole32.spec
> @@ -23,7 +23,7 @@
>  # CoCreateObjectInContext
>  # CoDeactivateObject
>  @ stdcall -stub CoDisableCallCancellation(ptr)
> -@ stdcall -stub CoDisconnectContext(long)
> +@ stdcall -stub -version=0x600+ CoDisconnectContext(long)
>  @ stdcall CoDisconnectObject(ptr long)
>  @ stdcall CoDosDateTimeToFileTime(long long ptr) kernel32.DosDateTimeToFileTime
>  @ stdcall -stub CoEnableCallCancellation(ptr)
-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.