Re: [ros-dev] [ros-diffs] [greatlrd] 28680: implement GdiConvertPalette, GdiConvertRegion

[Ged]

Hi Magnus.

Can you explain these please, they seem a bit weird?

Cheers,
Ged.

[e-mail] wrote:
> Author: greatlrd
> Date: Thu Aug 30 23:05:43 2007
> New Revision: 28680
>
> URL: http://svn.reactos.org/svn/reactos?rev=28680&view=rev
> Log:
> implement GdiConvertPalette, GdiConvertRegion
>
> Modified:
>     trunk/reactos/dll/win32/gdi32/misc/stubs.c
>
> Modified: trunk/reactos/dll/win32/gdi32/misc/stubs.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/misc/stubs....
> ==============================================================================
> --- trunk/reactos/dll/win32/gdi32/misc/stubs.c (original)
> +++ trunk/reactos/dll/win32/gdi32/misc/stubs.c Thu Aug 30 23:05:43 2007
> @@ -1431,15 +1431,13 @@
>  }
>
> /*
> @unimplemented
> @implemented
> */
>
> HPALETTE 
>  STDCALL
>  GdiConvertPalette(HPALETTE hpal)
>  {
> UNIMPLEMENTED;
> SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> return 0;
> return hpal;
>
> }
>
> /*
> @@ -1449,9 +1447,7 @@
>  STDCALL
>  GdiConvertRegion(HRGN hregion)
>  {
> UNIMPLEMENTED;
> SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> return 0;
> return hregion;
>
> }
>
> /*

[James Tabor]

Ged wrote:
> Hi Magnus.
>
> Can you explain these please, they seem a bit weird?
>
> Cheers,
> Ged.
>
> [e-mail] wrote:
> > Author: greatlrd
> > Date: Thu Aug 30 23:05:43 2007
> > New Revision: 28680
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=28680&view=rev
> > Log:
> > implement GdiConvertPalette, GdiConvertRegion
> >
> > Modified:
> >     trunk/reactos/dll/win32/gdi32/misc/stubs.c
> >
> > Modified: trunk/reactos/dll/win32/gdi32/misc/stubs.c
> > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/misc/stubs....
> > ==============================================================================
> > --- trunk/reactos/dll/win32/gdi32/misc/stubs.c (original)
> > +++ trunk/reactos/dll/win32/gdi32/misc/stubs.c Thu Aug 30 23:05:43 2007
> > @@ -1431,15 +1431,13 @@
> >  }
> >
> > /*
> > @unimplemented
> > @implemented
> > */
> >
> > HPALETTE 
> >  STDCALL
> >  GdiConvertPalette(HPALETTE hpal)
> >  {
> > UNIMPLEMENTED;
> > SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> > return 0;
> > return hpal;
> >
> > }
> >
> > /*
> > @@ -1449,9 +1447,7 @@
> >  STDCALL
> >  GdiConvertRegion(HRGN hregion)
> >  {
> > UNIMPLEMENTED;
> > SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> > return 0;
> > return hregion;
> >
> > }
> >
> > /*

The tests show they just pass gass. Win311 throw back! Still stuck on backward compatibility.
Thanks,
James