Re: [ros-dev] [ros-diffs] [sir_richard] 48475: [KERNEL32]: While working on the CMAKE branch, Amine and myself discovered a rather serious issue in kernel32 (and perhaps other libraries as well). Unlike rbuild, CMake does not allow you to export non-existant DLL functions (try it: add "poopyhead" in kernel32's exports under RBuild, and will it export "poopyhead", God knowing what that will actually link to). As an additional feature on top of the "allow non-existing functions to be exported" "feature", beca

[Timo Kreuzer]

sir_richard(a)svn.reactos.org wrote:
>   Author: sir_richard
>  Date: Sat Aug  7 05:02:58 2010
>  New Revision: 48475
>
>  URL: http://svn.reactos.org/svn/reactos?rev=48475&view=rev
>  Log:
>  [KERNEL32]: While working on the CMAKE branch, Amine and myself discovered a rather
> serious issue in kernel32 (and perhaps other libraries as well).  
I'm sure noone
else could have discovered this issue before. cmake was
the key! ;-)

>   Unlike rbuild, CMake does not allow you to export
> non-existant DLL functions (try it: add "poopyhead" in kernel32's exports
> under RBuild, and will it export "poopyhead", God knowing what that will
> actually link to).
>     
That's an undocumented rbuild feature, called api-out-of-thin-air. To
understand how it works, you must study quantum chaos theory.

>    there already exists a function for:
> *RtlSetLastNtStatusFromWin32Error*.
>     
I see, with cmake, this feature works on ntdll as well ;-p

Regards,
Timo

PS: build is broken.

[Sven Barth]

Hi!

Just a little question regarding commit-mails: Does the subject NEED to 
be the complete svn log message? This mail's subject line was that long 
that I'm not able to view the message itself in Thunderbird without 
writing a reply so that I can see the quoted message body.

Couldn't the component/system/process that converts the commits into 
mails for the diffs mailing list truncate the subject line? As far as I 
see it the log message is put into the mail's body as well and it's also 
nicer to view there because of line breaks. :)

Regards,
Sven