Re: [ros-diffs] [cwittich] 20095: better stubs for VerLanguageNameA/W (untested)

[Hartmut Birr]

cwittich(a)svn.reactos.com wrote:
>   better stubs for VerLanguageNameA/W (untested)
>  Modified: trunk/reactos/lib/kernel32/misc/stubs.c
>    
>  ------------------------------------------------------------------------
>  *Modified: trunk/reactos/lib/kernel32/misc/stubs.c*
>  --- trunk/reactos/lib/kernel32/misc/stubs.c	2005-12-11 23:53:23 UTC (rev 20094)
>  +++ trunk/reactos/lib/kernel32/misc/stubs.c	2005-12-12 00:06:38 UTC (rev 20095)
>  @@ -355,7 +355,9 @@
>       )
>   {
>       STUB;
>    
>  -    return 0;
>    
>  +    szLang = "Language Neutral\0";
>  +    nSize = sizeof(szLang) * sizeof(CHAR);
>  +    return sizeof(szLang) - 1;
>    
>   }
>   
>   
>  @@ -371,7 +373,9 @@
>    
>       )
>   {
>       STUB;
>    
>  -    return 0;
>    
>  +    szLang = L"Language Neutral\0";
>  +    nSize = sizeof(szLang) * sizeof(WCHAR);
>  +    return sizeof(szLang) - 1;
>    
>   }
>   
>   
>     
This change is wrong. szLang is pointer to a buffer, which will receive
a string. The return value must be the number of characters (in
VerLanguageNameW).

- Hartmut

[Brandon Turner]

He is in the process of reverting/fixing it right now.

Brandon

Hartmut Birr wrote:

>  cwittich(a)svn.reactos.com wrote:
>   
>
> >  better stubs for VerLanguageNameA/W (untested)
> > Modified: trunk/reactos/lib/kernel32/misc/stubs.c
> >   
> > ------------------------------------------------------------------------
> > *Modified: trunk/reactos/lib/kernel32/misc/stubs.c*
> > --- trunk/reactos/lib/kernel32/misc/stubs.c	2005-12-11 23:53:23 UTC (rev 20094)
> > +++ trunk/reactos/lib/kernel32/misc/stubs.c	2005-12-12 00:06:38 UTC (rev 20095)
> > @@ -355,7 +355,9 @@
> >      )
> >  {
> >      STUB;
> >   
> > -    return 0;
> >   
> > +    szLang = "Language Neutral\0";
> > +    nSize = sizeof(szLang) * sizeof(CHAR);
> > +    return sizeof(szLang) - 1;
> >   
> >  }
> >  
> >  
> > @@ -371,7 +373,9 @@
> >   
> >      )
> >  {
> >      STUB;
> >   
> > -    return 0;
> >   
> > +    szLang = L"Language Neutral\0";
> > +    nSize = sizeof(szLang) * sizeof(WCHAR);
> > +    return sizeof(szLang) - 1;
> >   
> >  }
> >  
> >  
> >   
> >     
> >  
> This change is wrong. szLang is pointer to a buffer, which will receive
> a string. The return value must be the number of characters (in
> VerLanguageNameW).
>
> - Hartmut
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
>
>   
>

[Christoph von Wittich]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>   
>  This change is wrong. szLang is pointer to a buffer, which will receive
>  a string. The return value must be the number of characters (in
>  VerLanguageNameW).
>   
Yes, I know... I will fix it.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (MingW32)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFDnMPH0ADPczu7wMoRAhZBAJwJUNbJ6sAM8MwcIcP/mSma18oVggCePcek
> o3IlHBKEUfw2n9KFod2IkIA=
> =qAHx
> -----END PGP SIGNATURE-----