Re: [ros-diffs] [ion] 18082: - Fix a bug in CSR Capture APIs

[Thomas Weidenmueller]

[e-mail] wrote:
> CsrCaptureMessageBuffer(CaptureBuffer,
>                      NULL,
>                      Size,
>                      (PVOID*)&Request.Data.PeekConsoleInputRequest.InputRecord);

The last parameter passed to CsrCaptureMessageBuffer in your changes
looks horribly wrong. The typecast hides the bug and shouldn't be
necessary, the compiler would've warned you that this is most likely wrong.

- Thomas

[Thomas Weidenmueller]

Thomas Weidenmueller wrote:
> The last parameter passed to CsrCaptureMessageBuffer in your changes
> looks horribly wrong. The typecast hides the bug and shouldn't be
> necessary, the compiler would've warned you that this is most likely wrong.

Nevermind, sorry about that. I thought that was an array variable,
apparently it has changed in the last months.

- Thomas

[Alex Ionescu]

Thomas Weidenmueller wrote:
> [e-mail] wrote:
> > CsrCaptureMessageBuffer(CaptureBuffer,
> >                      NULL,
> >                      Size,
> >                      (PVOID*)&Request.Data.PeekConsoleInputRequest.InputRecord);
>
> The last parameter passed to CsrCaptureMessageBuffer in your changes
> looks horribly wrong. The typecast hides the bug and shouldn't be
> necessary, the compiler would've warned you that this is most likely wrong.
> Thomas

Shoot first, ask questions later ;-).

At least someone reviews patches!

Best regards,
Alex Ionescu