Re: [ros-dev] [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if VMware is detected - This hack circumvents the main blocker that prevents enabling ACPI in trunk

[Aleksey Bragin]

Very nasty.

--------------------------------------------------
From: <cgutman(a)svn.reactos.org>
Sent: Wednesday, March 17, 2010 8:02 AM
To: <ros-diffs(a)reactos.org>
Subject: [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if VMware 
is detected - This hack circumvents the main blocker that prevents enabling 
ACPI in trunk

>   Author: cgutman
>  Date: Wed Mar 17 06:02:06 2010
>  New Revision: 46237
>
>  URL: http://svn.reactos.org/svn/reactos?rev=46237&view=rev
>  Log:
>  - Add a hack to disable ACPI if VMware is detected
>  - This hack circumvents the main blocker that prevents enabling ACPI in 
>  trunk
>
>  Modified:
>     trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
>
>  Modified: trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
>  URL: 
>
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/acpica/ta…
>  ==============================================================================
>  --- trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1] 
>  (original)
>  +++ trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1] 
>  Wed Mar 17 06:02:06 2010
>  @@ -592,6 +592,7 @@
>      UINT32                  Length;
>      UINT8                   *TableEntry;
>      ACPI_STATUS             Status;
>  +    ACPI_TABLE_HEADER       LocalHeader;
>
>
>      ACPI_FUNCTION_TRACE (TbParseRootTable);
>  @@ -645,6 +646,14 @@
>      }
>
>      AcpiTbPrintTableHeader (Address, Table);
>  +
>  +    AcpiTbCleanupTableHeader (&LocalHeader, Table);
>  +    if (strstr(LocalHeader.AslCompilerId, "VMW"))
>  +    {
>  +        ACPI_ERROR ((AE_INFO, "VMware detected; ACPI has been 
>  disabled\n"));
>  +        AcpiOsUnmapMemory (Table, sizeof (ACPI_TABLE_HEADER));
>  +        return_ACPI_STATUS (AE_ERROR);
>  +    }
>
>      /* Get the length of the full table, verify length and map entire 
>  table */
>
>
>

[Olaf Siejka]

ACPI doesnt work with vbox guest additions, which is a trunk blocker as
well, IMO. Patch provided by aicom fixes the crash but introduces/leaves the
following random crash:

err:(dll\win32\user32\windows\window.c:281) CreateWindowExA
RegisterSystemControls
Boot took 33447053948 cycles!
Interrupts: 2302 System Calls: 10824 Context Switches: 1389

*** Fatal System Error: 0x0000007f
(0x00000008,0x00000000,0x00000000,0x00000000)

Entered debugger on embedded INT3 at 0x0008:0x808dff98.
kdb:> bt
Eip:
<ntoskrnl.exe:dff99 (lib\rtl\i386\debug_asm.S:42
(RtlpBreakWithStatusInstruction))>
Frames:
<ntoskrnl.exe:a44f (ntoskrnl/ke/bug.c:1110 (KeBugCheckWithTf@24))>
<ntoskrnl.exe:269d (ntoskrnl/ke/i386/exp.c:92 (@KiRecordDr7@8))>
<ntoskrnl.exe:5f05 (ntoskrnl/ke/i386/traphdlr.c:522 (@KiTrap05Handler@4))>
<00000000>

2010/3/17 Aleksey Bragin &lt;aleksey(a)reactos.org&gt;

>   Very nasty.
>
>  --------------------------------------------------
>  From: &lt;cgutman(a)svn.reactos.org&gt;
>  Sent: Wednesday, March 17, 2010 8:02 AM
>  To: &lt;ros-diffs(a)reactos.org&gt;
>  Subject: [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if
>  VMware is detected - This hack circumvents the main blocker that prevents
>  enabling ACPI in trunk
>
>   Author: cgutman
> >   Date: Wed Mar 17 06:02:06 2010
> >  New Revision: 46237
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=46237&view=rev
> >  Log:
> >  - Add a hack to disable ACPI if VMware is detected
> >  - This hack circumvents the main blocker that prevents enabling ACPI in
> >  trunk
> >
> >  Modified:
> >    trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >
> >  Modified: trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >  URL:
> >
> > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/acpica/ta…
> >
> >  ==============================================================================
> >  --- trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
> >  (original)
> >  +++ trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
> >  Wed Mar 17 06:02:06 2010
> >  @@ -592,6 +592,7 @@
> >     UINT32                  Length;
> >     UINT8                   *TableEntry;
> >     ACPI_STATUS             Status;
> >  +    ACPI_TABLE_HEADER       LocalHeader;
> >
> >
> >     ACPI_FUNCTION_TRACE (TbParseRootTable);
> >  @@ -645,6 +646,14 @@
> >     }
> >
> >     AcpiTbPrintTableHeader (Address, Table);
> >  +
> >  +    AcpiTbCleanupTableHeader (&LocalHeader, Table);
> >  +    if (strstr(LocalHeader.AslCompilerId, "VMW"))
> >  +    {
> >  +        ACPI_ERROR ((AE_INFO, "VMware detected; ACPI has been
> >  disabled\n"));
> >  +        AcpiOsUnmapMemory (Table, sizeof (ACPI_TABLE_HEADER));
> >  +        return_ACPI_STATUS (AE_ERROR);
> >  +    }
> >
> >     /* Get the length of the full table, verify length and map entire table
> >  */
> >
> >
> >
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Gabriel ilardi]

With guest additions installed, I get this in vbox 3.1.2 while trying to shutdown from the
start button:

(ntoskrnl/po/poshtdwn.c:160) Disabling wake timers
(ntoskrnl/po/poshtdwn.c:164) Taking the system down
(ntoskrnl/po/poshtdwn.c:70) It's the final countdown...4
NTDDK: Pageable code called at IRQL > APC_LEVEL (2)
Assertion '0' failed at ARM³::CONTMEM line 251
PuTTYEntered debugger on embedded INT3 at 0x0008:0x808dfe12.
kdb:> bt
Eip:
<ntoskrnl.exe:dfe13 (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))>
Frames:
<ntoskrnl.exe:8a74a (ARM³::CONTMEM:251 (MiFreeContiguousMemory@4))>
<ntoskrnl.exe:8a892 (ARM³::CONTMEM:436 (MmFreeContiguousMemory@4))>
<VBoxVideo.sys:4541>
<VBoxVideo.sys:3c32>
<VBoxVideo.sys:3ee6>
<VIDEOPRT.SYS:2545 (drivers/video/videoprt/dispatch.c:46
(IntVideoPortResetDisplayParameters@8))>
<ntoskrnl.exe:53f95 (ntoskrnl/inbv/inbv.c:200 (InbvAcquireDisplayOwnership@0))>
<ntoskrnl.exe:c03bc (ntoskrnl/po/poshtdwn.c:37 (PopShutdownHandler@0))>
<ntoskrnl.exe:c0559 (ntoskrnl/po/poshtdwn.c:106 (PopShutdownSystem@4))>
<ntoskrnl.exe:c07bf (ntoskrnl/po/poshtdwn.c:165 (PopGracefulShutdown@4))>
<ntoskrnl.exe:4d075 (ntoskrnl/ex/work.c:162 (ExpWorkerThreadEntryPoint@4))>
<ntoskrnl.exe:cf91b (ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))>
<ntoskrnl.exe:54b0 (ntoskrnl/ke/i386/thrdini.c:64 (KiThreadStartup@0))>
<ntoskrnl.exe:cf8b7 (ntoskrnl/ps/thread.c:141 (PspSystemThreadStartup@8))>
<00000000>
kdb:>


Date: Wed, 17 Mar 2010 11:52:21 +0100
From: caemyr(a)gmail.com
To: ros-dev(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [cgutman] 46237: - Add a hack to disable	ACPI if VMware
is detected - This hack circumvents the main	blocker that prevents enabling ACPI in trunk

ACPI doesnt work with vbox guest additions, which is a trunk blocker as well, IMO. Patch
provided by aicom fixes the crash but introduces/leaves the following random crash:

err:(dll\win32\user32\windows\window.c:281) CreateWindowExA RegisterSystemControls

Boot took 33447053948 cycles!
Interrupts: 2302 System Calls: 10824 Context Switches: 1389

*** Fatal System Error: 0x0000007f
                       (0x00000008,0x00000000,0x00000000,0x00000000)

Entered debugger on embedded INT3 at 0x0008:0x808dff98.

kdb:> bt
Eip:
<ntoskrnl.exe:dff99 (lib\rtl\i386\debug_asm.S:42 (RtlpBreakWithStatusInstruction))>
Frames:
<ntoskrnl.exe:a44f (ntoskrnl/ke/bug.c:1110 (KeBugCheckWithTf@24))>
<ntoskrnl.exe:269d (ntoskrnl/ke/i386/exp.c:92 (@KiRecordDr7@8))>

<ntoskrnl.exe:5f05 (ntoskrnl/ke/i386/traphdlr.c:522 (@KiTrap05Handler@4))>
<00000000>

2010/3/17 Aleksey Bragin &lt;aleksey(a)reactos.org&gt;

Very nasty.



--------------------------------------------------

From: &lt;cgutman(a)svn.reactos.org&gt;

Sent: Wednesday, March 17, 2010 8:02 AM

To: &lt;ros-diffs(a)reactos.org&gt;

Subject: [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if VMware is detected -
This hack circumvents the main blocker that prevents enabling ACPI in trunk




Author: cgutman

Date: Wed Mar 17 06:02:06 2010

New Revision: 46237



URL: http://svn.reactos.org/svn/reactos?rev=46237&view=rev

Log:

- Add a hack to disable ACPI if VMware is detected

- This hack circumvents the main blocker that prevents enabling ACPI in trunk



Modified:

   trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c



Modified: trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c

URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/acpica/ta…


==============================================================================

--- trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1] (original)

+++ trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1] Wed Mar 17
06:02:06 2010

@@ -592,6 +592,7 @@

    UINT32                  Length;

    UINT8                   *TableEntry;

    ACPI_STATUS             Status;

+    ACPI_TABLE_HEADER       LocalHeader;





    ACPI_FUNCTION_TRACE (TbParseRootTable);

@@ -645,6 +646,14 @@

    }



    AcpiTbPrintTableHeader (Address, Table);

+

+    AcpiTbCleanupTableHeader (&LocalHeader, Table);

+    if (strstr(LocalHeader.AslCompilerId, "VMW"))

+    {

+        ACPI_ERROR ((AE_INFO, "VMware detected; ACPI has been disabled\n"));

+        AcpiOsUnmapMemory (Table, sizeof (ACPI_TABLE_HEADER));

+        return_ACPI_STATUS (AE_ERROR);

+    }



    /* Get the length of the full table, verify length and map entire table */










_______________________________________________

Ros-dev mailing list

Ros-dev(a)reactos.org

http://www.reactos.org/mailman/listinfo/ros-dev


 		 	   		  
_________________________________________________________________
Chiama e videochiama gratis su Messenger!
http://www.messenger.it/videoconversazioni.aspx

[Ros Arm]

I had told the channel not to do this because HAL ACPI does not exist yet. ACPI cannot
work without it, other than by random chance or coincidence.

-r

>   Very nasty.
>  
>  --------------------------------------------------
>  From: <cgutman(a)svn.reactos.org>
>  Sent: Wednesday, March 17, 2010 8:02 AM
>  To: <ros-diffs(a)reactos.org>
>  Subject: [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if VMware 
>  is detected - This hack circumvents the main blocker that prevents enabling 
>  ACPI in trunk
>  
> >   Author: cgutman
> >  Date: Wed Mar 17 06:02:06 2010
> >  New Revision: 46237
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=46237&view=rev
> >  Log:
> >  - Add a hack to disable ACPI if VMware is detected
> >  - This hack circumvents the main blocker that prevents enabling ACPI in 
> >  trunk
> >
> >  Modified:
> >     trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >
> >  Modified: trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >  URL: 
> >
> > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/acpica/ta…
> >  ==============================================================================
> >  --- trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1] 
> >  (original)
> >  +++ trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1] 
> >  Wed Mar 17 06:02:06 2010
> >  @@ -592,6 +592,7 @@
> >      UINT32                  Length;
> >      UINT8                   *TableEntry;
> >      ACPI_STATUS             Status;
> >  +    ACPI_TABLE_HEADER       LocalHeader;
> >
> >
> >      ACPI_FUNCTION_TRACE (TbParseRootTable);
> >  @@ -645,6 +646,14 @@
> >      }
> >
> >      AcpiTbPrintTableHeader (Address, Table);
> >  +
> >  +    AcpiTbCleanupTableHeader (&LocalHeader, Table);
> >  +    if (strstr(LocalHeader.AslCompilerId, "VMW"))
> >  +    {
> >  +        ACPI_ERROR ((AE_INFO, "VMware detected; ACPI has been 
> >  disabled\n"));
> >  +        AcpiOsUnmapMemory (Table, sizeof (ACPI_TABLE_HEADER));
> >  +        return_ACPI_STATUS (AE_ERROR);
> >  +    }
> >
> >      /* Get the length of the full table, verify length and map entire 
> >  table */
> >
> >
> >   
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Andrew Faulds]

What? The HAL doesn't support ACPI currently?!

On 17 March 2010 16:08, Ros Arm <ros.arm(a)reactos.org> wrote:

>   I had told the channel not to do this because HAL ACPI
> does not exist yet.
>  ACPI cannot work without it, other than by random chance or coincidence.
>
>  -r
>
> >   Very nasty.
> >
> >  --------------------------------------------------
> >  From: <cgutman(a)svn.reactos.org>
> >  Sent: Wednesday, March 17, 2010 8:02 AM
> >  To: <ros-diffs(a)reactos.org>
> >  Subject: [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if 
>  VMware
> >   is detected - This hack circumvents the main
> > blocker that prevents 
>  enabling
> >   ACPI in trunk
> >
> >  > Author: cgutman
> >  > Date: Wed Mar 17 06:02:06 2010
> >  > New Revision: 46237
> >  >
> >  > URL: http://svn.reactos.org/svn/reactos?rev=46237&view=rev
> >  > Log:
> >  > - Add a hack to disable ACPI if VMware is detected
> >  > - This hack circumvents the main blocker that prevents enabling ACPI in
> >  > trunk
> >  >
> >  > Modified:
> >  >    trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >  >
> >  > Modified: trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >  > URL:
> >  > 
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/acpica/ta…
> >   > 
> ==============================================================================
>  > > --- trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
>  > > (original)
>  > > +++ trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
>  > > Wed Mar 17 06:02:06 2010
>  > > @@ -592,6 +592,7 @@
>  > >     UINT32                  Length;
>  > >     UINT8                   *TableEntry;
>  > >     ACPI_STATUS             Status;
>  > > +    ACPI_TABLE_HEADER       LocalHeader;
> >   > 
> >   > 
>  > >     ACPI_FUNCTION_TRACE (TbParseRootTable);
>  > > @@ -645,6 +646,14 @@
>  > >     }
> >   > 
>  > >     AcpiTbPrintTableHeader
> (Address, Table);
>  > > +
>  > > +    AcpiTbCleanupTableHeader (&LocalHeader, Table);
>  > > +    if (strstr(LocalHeader.AslCompilerId, "VMW"))
>  > > +    {
>  > > +        ACPI_ERROR ((AE_INFO, "VMware detected; ACPI has been
>  > > disabled\n"));
>  > > +        AcpiOsUnmapMemory (Table, sizeof (ACPI_TABLE_HEADER));
>  > > +        return_ACPI_STATUS (AE_ERROR);
>  > > +    }
> >   > 
>  > >     /* Get the length of
> the full table, verify length and map entire
>  > > table */
> >   > 
> >   > 
> >   > 
>  >
>  > _______________________________________________
>  > Ros-dev mailing list
>  > Ros-dev(a)reactos.org
>  > http://www.reactos.org/mailman/listinfo/ros-dev
>
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  


-- 
Andrew Faulds (andrewros/andrewweb)
http://ajf.me/