36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord

[Sylvain Petreolle]

Isnt that condition always true ?

+    if ((pFaceName && nCount) ||
+        !(pFaceName && nCount))

Kind regards,
Sylvain Petreolle

Support artists, not multinationals - http://Iwouldntsteal.net
Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net

[James Tabor]

Hi,
It should be like this:

INT STDCALL GetTextFaceW(HDC hDC, int nCount,  LPWSTR lpFaceName)
{
    if (lpFaceName && nCount <= 0)
    {
        SetLastError(ERROR_INVALID_PARAMETER);
        return 0;
    }
    return NtGdiGetTextFaceW(hDC,nCount,lpFaceName,FALSE);
}
and....,

INT STDCALL GetTextFaceAliasW(HDC hdc, int cChar, LPWSTR pszOut)
{
    if ( pszOut && !cChar )
    {
        SetLastError(ERROR_INVALID_PARAMETER);
        return 0;
    }
   return NtGdiGetTextFaceW(hdc,cChar,pszOut,TRUE);
}

On Thu, Oct 16, 2008 at 4:14 PM, Sylvain Petreolle [e-mail] wrote:
> Isnt that condition always true ?
> if ((pFaceName && nCount) ||
>    !(pFaceName && nCount))
>
> Kind regards,
> Sylvain Petreolle

Thanks,
James