Are DBG=0 builds broken?

[WaxDragon]

I have been unable to boot or install a DBG=0 build since yesterday
(yesterday being the first time I have tried in a while).  Has anyone
tried a DBG=0 build either via bootcd or "make install"?  The bootcd
will load the drivers then stack fault VMWare, and just hang qemu.  A
"make install" seems to just hang.  The last DBG=0 build I have is
pre-rbuild, 176 versions ago.  Anyone have a working DBG=0 bootcd that
is more recent than mine?  I'm trying to narrow down the regression.

-rw-r--r--  1 1000 100 9.0M 2005-05-27 15:11
ReactOS-15546M_release.iso <-- This one works.
-rw-r--r--  1 1000 100  15M 2005-05-28 20:50 ReactOS-15606M.iso
-rw-r--r--  1 1000 100  15M 2005-05-29 16:43 ReactOS-15648:15668M.iso
-rw-r--r--  1 1000 100  15M 2005-05-28 21:36 ReactOS-15648M.iso
-rw-r--r--  1 1000 100  12M 2005-05-29 12:26 ReactOS-15648M.iso.zip
-rw-r--r--  1 1000 100  15M 2005-05-29 17:19 ReactOS-15671M.iso
-rw-r--r--  1 1000 100  15M 2005-05-30 09:42 ReactOS-15677M.iso
-rw-r--r--  1 1000 100  15M 2005-05-31 10:29 ReactOS-15695M.iso
-rw-r--r--  1 1000 100  15M 2005-05-31 12:42 ReactOS-15702M.iso
-rw-r--r--  1 1000 100  15M 2005-05-31 21:35 ReactOS-15710M.iso
-rw-r--r--  1 1000 100  15M 2005-06-01 16:25 ReactOS-15716M.iso
-rw-r--r--  1 1000 100  15M 2005-06-01 20:59 ReactOS-15722M.iso
-rw-r--r--  1 1000 100  15M 2005-06-01 21:46
ReactOS-15722M_release.iso <-- This one is broken.

WD
-- 
<kjk_hyperion> I have a penchant for mischief, property damage and stalking
<kjk_hyperion> and cheesecake, of course

[Hartmut Birr]

Hi,

I see the same. I think it is a problem of freeldr if freeldr is
compiled with the options for optimisation which are enabled by KDB=0.

- Hartmut

WaxDragon wrote:

>  I have been unable to boot or install a DBG=0 build
> since yesterday
> (yesterday being the first time I have tried in a while).  Has anyone
> tried a DBG=0 build either via bootcd or "make install"?  The bootcd
> will load the drivers then stack fault VMWare, and just hang qemu.  A
> "make install" seems to just hang.  The last DBG=0 build I have is
> pre-rbuild, 176 versions ago.  Anyone have a working DBG=0 bootcd that
> is more recent than mine?  I'm trying to narrow down the regression.
>
> -rw-r--r--  1 1000 100 9.0M 2005-05-27 15:11
> ReactOS-15546M_release.iso <-- This one works.
> -rw-r--r--  1 1000 100  15M 2005-05-28 20:50 ReactOS-15606M.iso
> -rw-r--r--  1 1000 100  15M 2005-05-29 16:43 ReactOS-15648:15668M.iso
> -rw-r--r--  1 1000 100  15M 2005-05-28 21:36 ReactOS-15648M.iso
> -rw-r--r--  1 1000 100  12M 2005-05-29 12:26 ReactOS-15648M.iso.zip
> -rw-r--r--  1 1000 100  15M 2005-05-29 17:19 ReactOS-15671M.iso
> -rw-r--r--  1 1000 100  15M 2005-05-30 09:42 ReactOS-15677M.iso
> -rw-r--r--  1 1000 100  15M 2005-05-31 10:29 ReactOS-15695M.iso
> -rw-r--r--  1 1000 100  15M 2005-05-31 12:42 ReactOS-15702M.iso
> -rw-r--r--  1 1000 100  15M 2005-05-31 21:35 ReactOS-15710M.iso
> -rw-r--r--  1 1000 100  15M 2005-06-01 16:25 ReactOS-15716M.iso
> -rw-r--r--  1 1000 100  15M 2005-06-01 20:59 ReactOS-15722M.iso
> -rw-r--r--  1 1000 100  15M 2005-06-01 21:46
> ReactOS-15722M_release.iso <-- This one is broken.
>
> WD
>   
>

[Ge van Geldorp]

>   From: Hartmut Birr
>  
>  I see the same. I think it is a problem of freeldr if freeldr 
>  is compiled with the options for optimisation which are 
>  enabled by KDB=0. 
I just did a DBG=0 compile, then installed only the resulting freeldr.sys
(with e.g. the installed ntoskrnl.exe still being DBG=1). Booted fine. After
installing everything, boot failed. So I really wonder if freeldr.sys is the
culprit.

Gé van Geldorp.

[Hartmut Birr]

Ge van Geldorp wrote:

> >  From: Hartmut
> > Birr
> >
> > I see the same. I think it is a problem of freeldr if freeldr 
> > is compiled with the options for optimisation which are 
> > enabled by KDB=0.
> >     
> >  
> I just did a DBG=0 compile, then installed only the resulting freeldr.sys
> (with e.g. the installed ntoskrnl.exe still being DBG=1). Booted fine. After
> installing everything, boot failed. So I really wonder if freeldr.sys is the
> culprit.
>  
I didn't see the boot screen from setupldr. That's why I'm the opinion
that freeldr/setupldr fails.

- Hartmut

[Ge van Geldorp]

>   From: Hartmut Birr
>  
>  I didn't see the boot screen from setupldr. That's why I'm the opinion
>  that freeldr/setupldr fails. 
If I create a DBG := 0 bootcd and boot from it in Vmware, I get a stack
fault. If I add a line "while (1) ;" in ntoskrnl\ke\main.c just before line
243 (2nd call to LdrSafePEProcessModule()), the boot process hangs (and I
presume it hangs in the while (1)).
Just for kicks, can you try adding a while (1) at the very top of _main() in
ntoskrnl\ke\main.c?

Gé van Geldorp.

[Hartmut Birr]

Ge van Geldorp wrote:

> >  From: Hartmut
> > Birr
> >
> > I didn't see the boot screen from setupldr. That's why I'm the opinion
> > that freeldr/setupldr fails.
> >     
> >  
> If I create a DBG := 0 bootcd and boot from it in Vmware, I get a stack
> fault. If I add a line "while (1) ;" in ntoskrnl\ke\main.c just before line
> 243 (2nd call to LdrSafePEProcessModule()), the boot process hangs (and I
> presume it hangs in the while (1)).
> Just for kicks, can you try adding a while (1) at the very top of _main() in
> ntoskrnl\ke\main.c?
>
> Gé van Geldorp.
>   
>  
Hi,

I get the same result. Previous Alex changes to the debug system, I've
enabled the bochs debug prints at compile time. Bochs was very helpful
in such situations. With the new debug system, I'm not able to do this.
I hate Alex changes, because they have nothing improved and I'm not able
to investigate in bugs in the early boot phase. Sorry, that I say this.

- Hartmut

[Ge van Geldorp]

Ok, I think I've found the problem. ntoskrnl.exe imported from msvcrt.dll...
Patch below seems to fix things for me, I need to do a DBG := 1 testbuild
before I commit.

Gé van Geldorp.

Index: ntoskrnl/ntoskrnl.xml
===================================================================
--- ntoskrnl/ntoskrnl.xml       (revision 15747)
+++ ntoskrnl/ntoskrnl.xml       (working copy)
@@ -346,4 +346,7 @@
                <file>token.c</file>
        </directory>
        <file>ntoskrnl.rc</file>
+       <linkerflag>-nostartfiles</linkerflag>
+       <linkerflag>-nostdlib</linkerflag>
+       <linkerflag>-lgcc</linkerflag>
 </module>
Index: lib/kjs/kjs.xml
===================================================================
--- lib/kjs/kjs.xml     (revision 15747)
+++ lib/kjs/kjs.xml     (working copy)
@@ -2,6 +2,7 @@
        <include base="kjs">.</include>
        <include base="kjs">src</include>
        <include base="kjs">include</include>
+        <define name="__NO_CTYPE_INLINES" />
        <directory name="ksrc">
                <file>setjmp.S</file>
                <file>longjmp.S</file>