Re: [ros-svn] [royce] 17517: invoke _generate_dsp() have it open the output file, and fix some path parsing and const issues.

[Royce Mitchell III]

[e-mail] wrote:
> invoke _generate_dsp() have it open the output file, and fix some path parsing and const issues.
>
> Updated files:
> trunk/reactos/tools/rbuild/backend/msvc/msvc.cpp
> trunk/reactos/tools/rbuild/backend/msvc/msvc.h
> trunk/reactos/tools/rbuild/backend/msvc/msvcmaker.cpp

"make msvc" now creates a DSW file and DSP files such that msvc6 can 
load them. I seriously doubt anything will build yet, tho.

[Royce Mitchell III]

Royce Mitchell III wrote:
> [e-mail] wrote:
> > invoke _generate_dsp() have it open the output file, and fix some 
> > path parsing and const issues.
> >
> > Updated files:
> > trunk/reactos/tools/rbuild/backend/msvc/msvc.cpp
> > trunk/reactos/tools/rbuild/backend/msvc/msvc.h
> > trunk/reactos/tools/rbuild/backend/msvc/msvcmaker.cpp
>
> "make msvc" now creates a DSW file and DSP files such that msvc6 can 
> load them. I seriously doubt anything will build yet, tho.

I meant to send this reply to 17518, you need 17518 for it to work, sorry.

[Saveliy Tretiakov]

Royce Mitchell III wrote:
> "make msvc" now creates a DSW file and DSP files such that msvc6 can 
> load them. I seriously doubt anything will build yet, tho.

bugs:
1. Header files are not added to project.
2. When I try to open a file in project, I get error message:
Project file D:\trunk\reactos\services\eventlog\services\eventlog\rpc.c 
does not exists.

^^^^^^^^^^^^^^^^^^

wrong path

[Royce Mitchell III]

Saveliy Tretiakov wrote:
> Royce Mitchell III wrote:
> > "make msvc" now creates a DSW file and DSP files such that msvc6 can 
> > load them. I seriously doubt anything will build yet, tho.
>
> bugs:
> Header files are not added to project.
> When I try to open a file in project, I get error message:
>
> Project file 
> D:\trunk\reactos\services\eventlog\services\eventlog\rpc.c does not 
> exists.

1. That's because header files aren't in the xml files. Getting them in 
the dsp's are going to be a lot of work.
2. Yes, sedwards pointed that out yesterday, files need to be dsp-relative.

Thanks!

[Steven Edwards]

Hi,

--- Royce Mitchell III [e-mail] wrote:
> That's because header files aren't in the xml files. Getting them in
>
> the dsp's are going to be a lot of work.

Do you mean the dlls private headers? We should be able to set a include path for private headers
and check the module.xml for PCH headers and use those. Wine dlls might be more of a pain because
of a lack of PCH.
> Yes, sedwards pointed that out yesterday, files need to be dsp-relative.

Thanks for the fix btw. I will try to do more testing tonight on my VMs and send you a wine
generated *.dsp

Thanks
Steven

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

[Royce Mitchell III]

Steven Edwards wrote:
> Do you mean the dlls private headers? We should be able to set a include path for private headers
> and check the module.xml for PCH headers and use those. Wine dlls might be more of a pain because
> of a lack of PCH.

Headers that belong to that module (dsp) specifically are added to the 
project so that when one is changed, all files depending on it are 
rebuilt too. It's not strictly necessary for them to be in there, but 
it's "nice". You don't want to add every single header that is found, 
only the ones in and under that module's directory.