Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one line of r63414

[Thomas Faber]

>   ---
> trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1] (original)
>  +++ trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1] Fri May 23 17:14:39 2014
>  @@ -459,7 +459,7 @@
>       startup.dwFlags = STARTF_USESHOWWINDOW;
>       startup.wShowWindow = psei->nShow;
>       dwCreationFlags = CREATE_UNICODE_ENVIRONMENT;
>  -    if (!(psei->fMask & SEE_MASK_NO_CONSOLE))
>  +    if (psei->fMask & SEE_MASK_NO_CONSOLE)
>           dwCreationFlags |= CREATE_NEW_CONSOLE;    
>       startup.lpTitle = (LPWSTR)(psei->fMask & (SEE_MASK_HASLINKNAME |
> SEE_MASK_HASTITLE) ? psei->lpClass : NULL); 

This is the opposite of what the documentation says?

[Christoph von Wittich]

This should be send to wine then.

-----Ursprüngliche Nachricht-----
Von: Ros-dev [mailto:[e-mail]] Im Auftrag von Thomas
Faber
Gesendet: Samstag, 24. Mai 2014 11:03
An: ros-dev(a)reactos.org
Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one
line of r63414

>   ---
> trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1] 
(original)
>   +++
> trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1] Fri May 
23 17:14:39 2014
>   @@ -459,7 +459,7 @@
>       startup.dwFlags = STARTF_USESHOWWINDOW;
>       startup.wShowWindow = psei->nShow;
>       dwCreationFlags = CREATE_UNICODE_ENVIRONMENT;
>  -    if (!(psei->fMask & SEE_MASK_NO_CONSOLE))
>  +    if (psei->fMask & SEE_MASK_NO_CONSOLE)
>           dwCreationFlags |= CREATE_NEW_CONSOLE;    
>       startup.lpTitle = (LPWSTR)(psei->fMask & (SEE_MASK_HASLINKNAME |
SEE_MASK_HASTITLE) ? psei->lpClass : NULL);


This is the opposite of what the documentation says?


_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Thomas Faber]

I don't understand. Wine seems to have it right.

 341     if (!(psei->fMask & SEE_MASK_NO_CONSOLE))
 342         dwCreationFlags |= CREATE_NEW_CONSOLE;

http://source.winehq.org/git/wine.git/blob/ee13e10cf6d05c7d08dfebb9f04c70eb…


On 2014-05-24 14:13, Christoph von Wittich wrote:
>   This should be send to wine then.
>  
>  -----Ursprüngliche Nachricht-----
>  Von: Ros-dev [mailto:[e-mail]] Im Auftrag von Thomas
>  Faber
>  Gesendet: Samstag, 24. Mai 2014 11:03
>  An: ros-dev(a)reactos.org
>  Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one
>  line of r63414
>  
> >   ---
> > trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1] 
>  (original)
> >   +++
> > trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1] Fri May 
>  23 17:14:39 2014
> >   @@ -459,7 +459,7 @@
> >       startup.dwFlags = STARTF_USESHOWWINDOW;
> >       startup.wShowWindow = psei->nShow;
> >       dwCreationFlags = CREATE_UNICODE_ENVIRONMENT;
> >  -    if (!(psei->fMask & SEE_MASK_NO_CONSOLE))
> >  +    if (psei->fMask & SEE_MASK_NO_CONSOLE)
> >           dwCreationFlags |= CREATE_NEW_CONSOLE;    
> >       startup.lpTitle = (LPWSTR)(psei->fMask & (SEE_MASK_HASLINKNAME | 
> SEE_MASK_HASTITLE) ? psei->lpClass : NULL);
>  
>  
>  This is the opposite of what the documentation says?