Re: [ros-dev] [ros-diffs] [greatlrd] 28055: user32 cleanup lite redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file nci tools changes (done of timo and me) frist part moving the w32ksvc.db and sysfuncs.lst where they belong

[Aleksey Bragin]

So, is it reverted?

iirc, I even marked those files as "shared with Wine" in the  
README.WINE file. I did the merging of Wine changes once or twice  
there, and it's not a big fun to go change-by-change, trace revision  
when it was changed, look up why and was it a necessary change or not.

WBR,
Aleksey Bragin.

On Aug 1, 2007, at 11:05 AM, Thomas Weidenmueller wrote:
> No it's not worth the hazzle because those changes result in *NO*
> optimizations anyway. The code that was changed were calls to
> InvalidateRect to NtUserInvalidateRect. Since InvalidateRect is  
> already
> forwarded to NtUserInvalidateRect this doesn't really improve  
> anything,
> it's the same overhead. These changes should be reverted, not just
> because it makes no sense to optimize these function calls even more
> because they're absolutely not time-critical.
>
> Please revert.
> Thomas
>
> Steven Edwards wrote:
> > On 7/31/07, [e-mail] [e-mail]  
> > wrote:
> > > user32 cleanup lite
> > > redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the  
> > > def file
> > > Modified:
> > >     trunk/reactos/dll/win32/user32/controls/button.c
> > >     trunk/reactos/dll/win32/user32/controls/combo.c