Re: [ros-dev] [ros-diffs] [tkreuzer] 57009: [NTOSKRNL] Try to fix crash detection in sysreg

[Timo Kreuzer]

Hi

I don't exactly know how testman is supposed to detect kernel crashes, 
by hope was that the crash detection failed, because of the strange 
characters at the beginning of the line, but that was obviously not the 
case.
Can someone look into it and fix it, we are wasting a lot of testing 
time due to this.

Thanks,
Timo

Am 31.07.2012 22:58, schrieb tkreuzer(a)svn.reactos.org:
>   Author: tkreuzer
>  Date: Tue Jul 31 20:58:37 2012
>  New Revision: 57009
>
>  URL: http://svn.reactos.org/svn/reactos?rev=57009&view=rev
>  Log:
>  [NTOSKRNL]
>  Try to fix crash detection in sysreg
>
>  Modified:
>       trunk/reactos/ntoskrnl/kdbg/kdb.c
>
>  Modified: trunk/reactos/ntoskrnl/kdbg/kdb.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.c?rev=57…
>  ==============================================================================
>  --- trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] (original)
>  +++ trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] Tue Jul 31 20:58:37 2012
>  @@ -1472,12 +1472,12 @@
>    
>            if (BreakPoint->Type == KdbBreakPointSoftware)
>            {
>  -            KdbpPrint("Entered debugger on breakpoint #%d: EXEC
> 0x%04x:0x%08x\n",
>  +            KdbpPrint("\nEntered debugger on breakpoint #%d: EXEC
> 0x%04x:0x%08x\n",
>                          KdbLastBreakPointNr, TrapFrame->SegCs & 0xffff,
> TrapFrame->Eip);
>            }
>            else if (BreakPoint->Type == KdbBreakPointHardware)
>            {
>  -            KdbpPrint("Entered debugger on breakpoint #%d: %s 0x%08x\n",
>  +            KdbpPrint("\nEntered debugger on breakpoint #%d: %s 0x%08x\n",
>                          KdbLastBreakPointNr,
>                         (BreakPoint->Data.Hw.AccessType == KdbAccessRead) ?
> "READ" :
>                         ((BreakPoint->Data.Hw.AccessType == KdbAccessWrite) ?
> "WRITE" :
>  @@ -1545,7 +1545,7 @@
>                    return kdHandleException;
>                }
>    
>  -            KdbpPrint("Entered debugger on unexpected debug trap!\n");
>  +            KdbpPrint("\nEntered debugger on unexpected debug trap!\n");
>            }
>        }
>        else if (ExceptionCode == STATUS_BREAKPOINT)
>  @@ -1560,7 +1560,7 @@
>                return kdHandleException;
>            }
>    
>  -        KdbpPrint("Entered debugger on embedded INT3 at 0x%04x:0x%08x.\n",
>  +        KdbpPrint("\nEntered debugger on embedded INT3 at 0x%04x:0x%08x.\n",
>                      TrapFrame->SegCs & 0xffff, TrapFrame->Eip - 1);
>        }
>        else
>  @@ -1574,7 +1574,7 @@
>                return ContinueType;
>            }
>    
>  -        KdbpPrint("Entered debugger on %s-chance exception (Exception Code: 0x%x)
> (%s)\n",
>  +        KdbpPrint("\nEntered debugger on %s-chance exception (Exception Code: 0x%x)
> (%s)\n",
>                      FirstChance ? "first" : "last", ExceptionCode,
> ExceptionString);
>    
>            if (ExceptionCode == STATUS_ACCESS_VIOLATION &&
>
>
>