Re: [ros-dev] [ros-diffs] [hbelusca] 74742: [USETUP]: Creating a registry key with zero access is just plainly invalid. Fix it. It was not caught before because, we never ever booted a 1st-stage setup with a valid mounted e... - Ros-dev

2 Jun 2017


      On 2017-06-02 02:44, hbelusca@svn.reactos.org wrote:
...
@@ -341,7 +341,7 @@
      }
  InitializeObjectAttributes(&ObjectAttributes, &ServicesU, OBJ_CASE_INSENSITIVE, NULL, NULL);


Status = NtCreateKey(&hServices, 0, &ObjectAttributes, 0, NULL, 0, NULL);


Status = NtCreateKey(&hServices, KEY_ALL_ACCESS, &ObjectAttributes, 0, NULL, 0, NULL);
 if (!NT_SUCCESS(Status))
 {
     DPRINT1("NtCreateKey('%wZ') failed with status 0x%08lx\n", &ServicesU, Status);

It doesn't really need full access, does it? Could have gone for
something closer to the original, like READ_CONTROL.

    