Re: [ros-dev] [ros-diffs] [jimtabor] 44575: [Win32k] - Michael Martin found a create window and crash exit issue by testing programs from http://www.magma.ca/~wjr/ PEview. Fixed by replacing UserFreeWindowInfo with co_UserDestroyWindow at cleanup exi

[James Tabor]

Hi,
Let us take in an example from the PROCESS/THREADINFO merge or
morphing. It was all done in small steps and it also needed more
structure support to make the move possible. The same is going on with
the move to Wnd. Naming the entries in WINDOW_OBJECT the same as Wnd
makes it just as easy so when the WINDOW_OBJECT is removed the minimum
changes are made. This too includes new code to replace missing
entries in Wnd that had been added to WINDOW_OBJECT. This is the new
support that is need. Another example is LastChild from WINDOW_OBJECT,
support to replace it will need to be added.

This is the safest way to merge and morph to the new structure without
killing ReactOS in the process.
Thanks,
James

On Mon, Dec 14, 2009 at 8:02 AM, Timo Kreuzer [e-mail] wrote:
> I don't see any use in renaming the WINDOW_OBJECT structures.
> spwndXxx means shared pointer to a WND, this does not reflect it's
> current usage in WINDOW_OBJECT.
> We already have a WND and it has spwndXxx members and they are in use.
> You should rather try to get rid of them completely inside WINDOW_OBJECT
> and only use the ones from WND instead.
> But that's probably the last move after all the rest is gone.
>
> Anyway, as long as we end up with the WND structure only, do as you like
> on the way to there.
>
> Regards,
> Timo