Re: [ros-dev] [ros-diffs] [jgardou] 57124: [WINED3D] - MSVC needs INFINITY and NAN from wine/port.h. It can't be included from a header Will be sent upstream

[Thomas Faber]

Hi,

On 2012-08-21 15:38, jgardou(a)svn.reactos.org wrote:
>  
> URL:http://svn.reactos.org/svn/reactos?rev=57124&view=rev
>  Log:
>  [WINED3D]
>  - MSVC needs INFINITY and NAN from wine/port.h.
>  It can't be included from a header
>  Will be sent upstream 
can you explain what's wrong with including it from a header?
I was under the impression we had fixed the infinity/nan stuff properly
on Wine's side by adding it all to port.h.

Thanks!

-Thomas

[Jérôme Gardou]

Hi.

I have no idea. I wanted to send the first patch to wine, and when 
testing the compilation under linux, I had this error "wine/port.h can't 
be included from a header." (or something like this).

That was before I discovered that Wine code base is good regarding this 
issue, all source files include it before wined3d_private.h. It's just 
that our wined3d is slightly outdated. A sync would permanently solve 
this issue.

Cheers!
Jérôme.

Thomas Faber a écrit :
>   Hi,
>
>  On 2012-08-21 15:38, jgardou(a)svn.reactos.org wrote:
> >  
> > URL:http://svn.reactos.org/svn/reactos?rev=57124&view=rev
> >  Log:
> >  [WINED3D]
> >  - MSVC needs INFINITY and NAN from wine/port.h.
> >  It can't be included from a header
> >  Will be sent upstream 
>  can you explain what's wrong with including it from a header?
>  I was under the impression we had fixed the infinity/nan stuff properly
>  on Wine's side by adding it all to port.h.
>
>  Thanks!
>
>  -Thomas
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Kamil Hornicek]

Let's sync it then. If no-one is willing to do it I'll sync it when I 
get home later this week.

Regards
Kamil

Dne 21.8.2012 16:43, Jérôme Gardou napsal(a):
>   Hi.
>
>  I have no idea. I wanted to send the first patch to wine, and when
>  testing the compilation under linux, I had this error "wine/port.h can't
>  be included from a header." (or something like this).
>
>  That was before I discovered that Wine code base is good regarding this
>  issue, all source files include it before wined3d_private.h. It's just
>  that our wined3d is slightly outdated. A sync would permanently solve
>  this issue.
>
>  Cheers!
>  Jérôme.
>
>  Thomas Faber a écrit :
> >   Hi,
> >
> >  On 2012-08-21 15:38, jgardou(a)svn.reactos.org wrote:
> > >  
> > > URL:http://svn.reactos.org/svn/reactos?rev=57124&view=rev
> > >  Log:
> > >  [WINED3D]
> > >  - MSVC needs INFINITY and NAN from wine/port.h.
> > >  It can't be included from a header
> > >  Will be sent upstream 
> >  can you explain what's wrong with including it from a header?
> >  I was under the impression we had fixed the infinity/nan stuff properly
> >  on Wine's side by adding it all to port.h.
> >
> >  Thanks!
> >
> >  -Thomas
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev 
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Thomas Faber]

That'd be great!

This sync is kind of overdue anyway, and I haven't really felt qualified
to do D3D stuff.

Thanks!


On 2012-08-21 17:17, Kamil Hornicek wrote:
>   Let's sync it then. If no-one is willing to do it
> I'll sync it when I
>  get home later this week.
>
>  Regards
>  Kamil
>
>  Dne 21.8.2012 16:43, Jérôme Gardou napsal(a):
> > Hi.
> >
> > I have no idea. I wanted to send the first patch to wine, and when
> > testing the compilation under linux, I had this error "wine/port.h can't
> > be included from a header." (or something like this).
> >
> > That was before I discovered that Wine code base is good regarding this
> > issue, all source files include it before wined3d_private.h. It's just
> > that our wined3d is slightly outdated. A sync would permanently solve
> > this issue.
> >
> > Cheers!
> > Jérôme.
> >
> > Thomas Faber a écrit :
> >> Hi,
> >>
> >> On 2012-08-21 15:38, jgardou(a)svn.reactos.org wrote:
> >>> URL:http://svn.reactos.org/svn/reactos?rev=57124&view=rev
> >>> Log:
> >>> [WINED3D]
> >>> - MSVC needs INFINITY and NAN from wine/port.h.
> >>> It can't be included from a header
> >>> Will be sent upstream
> >>
> >> can you explain what's wrong with including it from a header?
> >> I was under the impression we had fixed the infinity/nan stuff properly
> >> on Wine's side by adding it all to port.h.
> >>
> >> Thanks!
> >>
> >> -Thomas