Re: [ros-dev] [ros-diffs] [tkreuzer] 50942: [WIN32K] Do raster operation on 4 bytes instead of only 3. Fixes ... maybe noone has noticed yet ; -)

[Colin Finck]

[e-mail] wrote:
> Do raster operation on 4 bytes instead of only 3.

Quoting jgardou's commit before:
> When applying raster operation, do so only on 24 bits, we don't
> support alpha channel in win32k

I have no idea about DIB code, but just from the commit message I 
presume that this change to 24 bits has happened deliberately.

- Colin

[Jérôme Gardou]

Colin Finck a écrit :
> [e-mail] wrote:
> > Do raster operation on 4 bytes instead of only 3.
>
> Quoting jgardou's commit before:
> > When applying raster operation, do so only on 24 bits, we don't
> > support alpha channel in win32k
>
> I have no idea about DIB code, but just from the commit message I 
> presume that this change to 24 bits has happened deliberately.
> Colin
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

You broke VLC icons in 32bpp

[Timo Kreuzer]

Am 01.03.2011 11:16, schrieb Colin Finck:
> [e-mail] wrote:
> > Do raster operation on 4 bytes instead of only 3.
>
> Quoting jgardou's commit before:
> > When applying raster operation, do so only on 24 bits, we don't
> > support alpha channel in win32k
>
> I have no idea about DIB code, but just from the commit message I 
> presume that this change to 24 bits has happened deliberately.

Probably, but that doesn't make it correct ;-)

The MaskBlt tests show that we should apply the operation on all 32 bits.
Also it will be applied on the bits of mono bitmaps, which can lead to 
undesired results if 3/4 of the pixels are simply black. Please have a 
look at 2nd stage installer (disabled buttons)

Timo