Re: [ros-dev] [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim ...

[Ged Murphy]

Would it not be better to do all this in C++ and let wine write a C interface around it?
When we're trying to move to C++, it seems like a step backwards in order to support
wine's insistence on using C
-----Original Message-----
From: Ros-diffs [mailto:[e-mail]] On Behalf Of
mjansen(a)svn.reactos.org
Sent: 28 May 2016 17:43
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329
Implement some macro's and functions that help when registering shims. These are all
written in C, so that wine can use the shim ...
Author: mjansen
Date: Sat May 28 16:42:57 2016
New Revision: 71439
URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev
Log:
[APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and
functions that help when registering shims.
These are all written in C, so that wine can use the shim libraries as well.

[David Quintana (gigaherz)]

Wine doesn't wrap C++, they just simply don't allow C in their codebase,
period. It's annoying.
On 31 May 2016 at 11:32, Ged Murphy <gedmurphy.maillists(a)gmail.com> wrote:
>   Would it not be better to do all this in C++ and let
> wine write a C
>  interface around it?
>  When we're trying to move to C++, it seems like a step backwards in order
>  to support wine's insistence on using C
>  -----Original Message-----
>  From: Ros-diffs [mailto:[e-mail]] On Behalf Of
>  mjansen(a)svn.reactos.org
>  Sent: 28 May 2016 17:43
>  To: ros-diffs(a)reactos.org
>  Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib
>  implementation. CORE-11329 Implement some macro's and functions that help
>  when registering shims. These are all written in C, so that wine can use
>  the shim ...
>  Author: mjansen
>  Date: Sat May 28 16:42:57 2016
>  New Revision: 71439
>  URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev
>  Log:
>  [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's
>  and functions that help when registering shims.
>  These are all written in C, so that wine can use the shim libraries as
>  well.
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Zachary Gorden]

Question actually still stands though. If wine is not inclined to use our
code just because it's in C++, should that stop us from using it? We
already basically split with shell32.
On Tue, May 31, 2016 at 4:45 AM, David Quintana (gigaherz) <
gigaherz(a)gmail.com&gt; wrote:
>   Wine doesn't wrap C++, they just simply don't
> allow C in their codebase,
>  period. It's annoying.
>  On 31 May 2016 at 11:32, Ged Murphy &lt;gedmurphy.maillists(a)gmail.com&gt; wrote:
> >   Would it not be better to do all this in C++ and
> > let wine write a C
> >  interface around it?
> >  When we're trying to move to C++, it seems like a step backwards in order
> >  to support wine's insistence on using C
> >  -----Original Message-----
> >  From: Ros-diffs [mailto:[e-mail]] On Behalf Of
> >  mjansen(a)svn.reactos.org
> >  Sent: 28 May 2016 17:43
> >  To: ros-diffs(a)reactos.org
> >  Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib
> >  implementation. CORE-11329 Implement some macro's and functions that help
> >  when registering shims. These are all written in C, so that wine can use
> >  the shim ...
> >  Author: mjansen
> >  Date: Sat May 28 16:42:57 2016
> >  New Revision: 71439
> >  URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev
> >  Log:
> >  [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's
> >  and functions that help when registering shims.
> >  These are all written in C, so that wine can use the shim libraries as
> >  well.
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[David Quintana (gigaherz)]

Sorry I forgot to clarify my stance on that part: no, wine shouldn't be a
reason to NOT use C++. I only meant that if we do really want to send that
upsteam, then C++ won't be accepted. I was at work, so I haven't even
looked if the edits are in wine code or not.
On 31 May 2016 at 16:28, Zachary Gorden <drakekaizer666(a)gmail.com> wrote:
>   Question actually still stands though. If wine is not
> inclined to use our
>  code just because it's in C++, should that stop us from using it? We
>  already basically split with shell32.
>  On Tue, May 31, 2016 at 4:45 AM, David Quintana (gigaherz) <
>  gigaherz(a)gmail.com&gt; wrote:
> >   Wine doesn't wrap C++, they just simply
> > don't allow C in their codebase,
> >  period. It's annoying.
> >  On 31 May 2016 at 11:32, Ged Murphy &lt;gedmurphy.maillists(a)gmail.com&gt;
> >  wrote:
> > >   Would it not be better to do all this in C++ and
> > > let wine write a C
> > >  interface around it?
> > >  When we're trying to move to C++, it seems like a step backwards in
> > >  order to support wine's insistence on using C
> > >  -----Original Message-----
> > >  From: Ros-diffs [mailto:[e-mail]] On Behalf Of
> > >  mjansen(a)svn.reactos.org
> > >  Sent: 28 May 2016 17:43
> > >  To: ros-diffs(a)reactos.org
> > >  Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib
> > >  implementation. CORE-11329 Implement some macro's and functions that help
> > >  when registering shims. These are all written in C, so that wine can use
> > >  the shim ...
> > >  Author: mjansen
> > >  Date: Sat May 28 16:42:57 2016
> > >  New Revision: 71439
> > >  URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev
> > >  Log:
> > >  [APPHELP] Begin shimlib implementation. CORE-11329 Implement some
> > >  macro's and functions that help when registering shims.
> > >  These are all written in C, so that wine can use the shim libraries as
> > >  well.
> > >  _______________________________________________
> > >  Ros-dev mailing list
> > >  Ros-dev(a)reactos.org
> > >  http://www.reactos.org/mailman/listinfo/ros-dev
> > >  
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Mark Jansen]

The initial idea was to send the apphelp.dll to wine (since some stuff is
also based on a wine fork),
and implement the shims on our end.
There was also some interest from the wine-staging guys in this concept,
so to make porting easier I did develop most of it in C.
If there is no interest in this anymore from wine-staging, then we can go
ahead and use c++ (and proper wchar_t usage),
but since we also use alot of their code, I thought it no more than fair
that they could also use some of ours.
On Tue, May 31, 2016 at 4:33 PM, David Quintana (gigaherz) <
gigaherz(a)gmail.com&gt; wrote:
>   Sorry I forgot to clarify my stance on that part: no,
> wine shouldn't be a
>  reason to NOT use C++. I only meant that if we do really want to send that
>  upsteam, then C++ won't be accepted. I was at work, so I haven't even
>  looked if the edits are in wine code or not.
>  On 31 May 2016 at 16:28, Zachary Gorden &lt;drakekaizer666(a)gmail.com&gt; wrote:
> >   Question actually still stands though. If wine is
> > not inclined to use our
> >  code just because it's in C++, should that stop us from using it? We
> >  already basically split with shell32.
> >  On Tue, May 31, 2016 at 4:45 AM, David Quintana (gigaherz) <
> >  gigaherz(a)gmail.com&gt; wrote:
> > >   Wine doesn't wrap C++, they just simply
> > > don't allow C in their codebase,
> > >  period. It's annoying.
> > >  On 31 May 2016 at 11:32, Ged Murphy &lt;gedmurphy.maillists(a)gmail.com&gt;
> > >  wrote:
> > > >   Would it not be better to do all this in C++ and
> > > > let wine write a C
> > > >  interface around it?
> > > >  When we're trying to move to C++, it seems like a step backwards in
> > > >  order to support wine's insistence on using C
> > > >  -----Original Message-----
> > > >  From: Ros-diffs [mailto:[e-mail]] On Behalf Of
> > > >  mjansen(a)svn.reactos.org
> > > >  Sent: 28 May 2016 17:43
> > > >  To: ros-diffs(a)reactos.org
> > > >  Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib
> > > >  implementation. CORE-11329 Implement some macro's and functions that help
> > > >  when registering shims. These are all written in C, so that wine can use
> > > >  the shim ...
> > > >  Author: mjansen
> > > >  Date: Sat May 28 16:42:57 2016
> > > >  New Revision: 71439
> > > >  URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev
> > > >  Log:
> > > >  [APPHELP] Begin shimlib implementation. CORE-11329 Implement some
> > > >  macro's and functions that help when registering shims.
> > > >  These are all written in C, so that wine can use the shim libraries as
> > > >  well.
> > > >  _______________________________________________
> > > >  Ros-dev mailing list
> > > >  Ros-dev(a)reactos.org
> > > >  http://www.reactos.org/mailman/listinfo/ros-dev
> > > >  
> > >  _______________________________________________
> > >  Ros-dev mailing list
> > >  Ros-dev(a)reactos.org
> > >  http://www.reactos.org/mailman/listinfo/ros-dev
> > >  
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>