Re: [ros-dev] [ros-diffs] [dgorbachev] 26555: Patch by Sbs (sbarthes [at] gmail [dot] com). Bugzilla report #2137.

[Aleksey]

----- Original Message ----- 
From: <dgorbachev(a)svn.reactos.org>
To: <ros-diffs(a)reactos.org>
Sent: Saturday, April 28, 2007 8:02 AM
Subject: [ros-diffs] [dgorbachev] 26555: Patch by Sbs (sbarthes [at] gmail 
[dot] com). Bugzilla report #2137.


>   Author: dgorbachev
>  Date: Sat Apr 28 10:02:22 2007
>  New Revision: 26555
>
>  URL: http://svn.reactos.org/svn/reactos?rev=26555&view=rev
>  Log:
>  Patch by Sbs (sbarthes [at] gmail [dot] com). Bugzilla report #2137. 
>   -    _stprintf(Text, _T("%d%%"),
> (int)CpuUsage);
>  +    wsprintf(Text, _T("%d%%"), (int)CpuUsage); 
Is this a correct change? IIRC, I talked with some dev (hpoussin?) about 
this, and he said those changes shouldn't be done.


WBR,
Aleksey Bragin.

[Thomas Weidenmueller]

They are wrong. _stprintf is fine.

- Thomnas

Aleksey wrote:
>   ----- Original Message ----- 
>  From: <dgorbachev(a)svn.reactos.org>
>  To: <ros-diffs(a)reactos.org>
>  Sent: Saturday, April 28, 2007 8:02 AM
>  Subject: [ros-diffs] [dgorbachev] 26555: Patch by Sbs (sbarthes [at] gmail 
>  [dot] com). Bugzilla report #2137.
>  
>  
> >   Author: dgorbachev
> >  Date: Sat Apr 28 10:02:22 2007
> >  New Revision: 26555
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=26555&view=rev
> >  Log:
> >  Patch by Sbs (sbarthes [at] gmail [dot] com). Bugzilla report #2137. 
>  
> >   -    _stprintf(Text, _T("%d%%"),
> > (int)CpuUsage);
> >  +    wsprintf(Text, _T("%d%%"), (int)CpuUsage); 
>  
>  Is this a correct change? IIRC, I talked with some dev (hpoussin?) about 
>  this, and he said those changes shouldn't be done.
>  
>  
>  WBR,
>  Aleksey Bragin. 
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Stephane BARTHES]

When compiling _stprintf with msvc the 2nd parameter should be a size
and not a string pointer. So tha app does not start.

I talked about that on the irc chan and was directed to use wsprintf.
which compiles and run both on msvc and gcc without chnaging the
params list.

It this is not the proper function to use, let's change it to whatever
is required, but the _stprintf does not work when compiling with msvc.

sbs

On 4/28/07, Thomas Weidenmueller <w3seek(a)reactos.com> wrote:
>   They are wrong. _stprintf is fine.
>
>  - Thomnas
>
>  Aleksey wrote:
> >   ----- Original Message -----
> >  From: <dgorbachev(a)svn.reactos.org>
> >  To: <ros-diffs(a)reactos.org>
> >  Sent: Saturday, April 28, 2007 8:02 AM
> >  Subject: [ros-diffs] [dgorbachev] 26555: Patch by Sbs (sbarthes [at] gmail
> >  [dot] com). Bugzilla report #2137.
> >
> >
> > >   Author: dgorbachev
> > >  Date: Sat Apr 28 10:02:22 2007
> > >  New Revision: 26555
> > >
> > >  URL: http://svn.reactos.org/svn/reactos?rev=26555&view=rev
> > >  Log:
> > >  Patch by Sbs (sbarthes [at] gmail [dot] com). Bugzilla report #2137. 
> > >   -    _stprintf(Text, _T("%d%%"),
> > > (int)CpuUsage);
> > >  +    wsprintf(Text, _T("%d%%"), (int)CpuUsage); 
> >  Is this a correct change? IIRC, I talked with some dev (hpoussin?) about
> >  this, and he said those changes shouldn't be done.
> >
> >
> >  WBR,
> >  Aleksey Bragin.
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>