Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

[Pierre Schweitzer]

On 15/06/2014 19:47, [e-mail] wrote:
> /* Trick: on Windows, pressing the CTRL key forces the task to be ended */
> BOOL ForceEndTask = !!(GetKeyState(VK_CONTROL) & 0x8000);

Was it really meant to be '!!'?
-- 
Pierre Schweitzer<pierre at reactos.org>
System Administrator
ReactOS Foundation

[Ged Murphy]

Yes, the double negate is a little trick to give you either a 1 or a 0 instead of the value of the operation.

-----Original Message-----
From: Ros-dev [mailto:[e-mail]] On Behalf Of Pierre Schweitzer
Sent: 16 June 2014 07:31
To: [e-mail]
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

On 15/06/2014 19:47, [e-mail] wrote:
> /* Trick: on Windows, pressing the CTRL key forces the task to be ended */
> BOOL ForceEndTask = !!(GetKeyState(VK_CONTROL) & 0x8000);

Was it really meant to be '!!'?

--
Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

[David Quintana (gigaherz)]

It's equivalent to writing "<something> != 0", although less readable. I
have no idea if compilers actually generate better code for it, or people
just do it because it's shorter to type.

On 16 June 2014 11:09, Ged Murphy [e-mail] wrote:
> Yes, the double negate is a little trick to give you either a 1 or a 0
> instead of the value of the operation.
>
> -----Original Message-----
> From: Ros-dev [mailto:[e-mail]] On Behalf Of Pierre
> Schweitzer
> Sent: 16 June 2014 07:31
> To: [e-mail]
> Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the
> EndTask API to kill tasks.
>
> On 15/06/2014 19:47, [e-mail] wrote:
> > /* Trick: on Windows, pressing the CTRL key forces the task to be
>
> ended */
> > BOOL ForceEndTask = !!(GetKeyState(VK_CONTROL) & 0x8000);
>
> Was it really meant to be '!!'?
>
> --
> Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS
> Foundation
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Ged Murphy]

They produce the same asm.

From: Ros-dev [mailto:[e-mail]] On Behalf Of David Quintana (gigaherz)
Sent: 16 June 2014 11:10
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

It's equivalent to writing "<something> != 0", although less readable. I have no idea if compilers actually generate better code for it, or people just do it because it's shorter to type.

On 16 June 2014 11:09, Ged Murphy <[e-mail] mailto:[e-mail] > wrote:

Yes, the double negate is a little trick to give you either a 1 or a 0 instead of the value of the operation.

-----Original Message-----
From: Ros-dev [mailto:[e-mail] mailto:[e-mail] ] On Behalf Of Pierre Schweitzer
Sent: 16 June 2014 07:31
To: [e-mail] mailto:[e-mail] 
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

On 15/06/2014 19:47, [e-mail] mailto:[e-mail]  wrote:
> /* Trick: on Windows, pressing the CTRL key forces the task to be ended */
> BOOL ForceEndTask = !!(GetKeyState(VK_CONTROL) & 0x8000);

Was it really meant to be '!!'?

--
Pierre Schweitzer<pierre at reactos.org http://reactos.org > System Administrator ReactOS Foundation

_______________________________________________
Ros-dev mailing list
[e-mail] mailto:[e-mail] 
http://www.reactos.org/mailman/listinfo/ros-dev

[Hermès BÉLUSCA - MAÏTO]

+1 @ Ged, yes I prefer having a 1 or 0 instead of something else (in case somebody after makes a “ForceEndTask == TRUE” comparison instead of just checking for non-zero value of ForceEndTask).

H.

De : Ros-dev [mailto:[e-mail]] De la part de Ged Murphy
Envoyé : lundi 16 juin 2014 12:48
À : 'ReactOS Development List'
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

They produce the same asm.

From: Ros-dev [mailto:[e-mail]] On Behalf Of David Quintana (gigaherz)
Sent: 16 June 2014 11:10
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

It's equivalent to writing "<something> != 0", although less readable. I have no idea if compilers actually generate better code for it, or people just do it because it's shorter to type.

On 16 June 2014 11:09, Ged Murphy [e-mail] wrote:

Yes, the double negate is a little trick to give you either a 1 or a 0 instead of the value of the operation.

-----Original Message-----
From: Ros-dev [mailto:[e-mail]] On Behalf Of Pierre Schweitzer
Sent: 16 June 2014 07:31
To: [e-mail]
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

On 15/06/2014 19:47, [e-mail] wrote:
> /* Trick: on Windows, pressing the CTRL key forces the task to be ended */
> BOOL ForceEndTask = !!(GetKeyState(VK_CONTROL) & 0x8000);

Was it really meant to be '!!'?

--
Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev