Re: [ros-dev] [ros-diffs] [cgutman] 37247: - Close the connection before freeing it

[Aleksey Bragin]

Does TCPClose  do what was written in comments (cancelling all  
pending requests)? I wonder if it was that simple, why it wasn't  
implemented this way before? ;)


On Nov 7, 2008, at 10:12 PM, cgutman(a)svn.reactos.org wrote:

>   Author: cgutman
>  Date: Fri Nov  7 13:12:26 2008
>  New Revision: 37247
>
>  URL: http://svn.reactos.org/svn/reactos?rev=37247&view=rev
>  Log:
>   - Close the connection before freeing it
>
>  Modified:
>      branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c
>
>  Modified: branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/ 
>  tcp.c
>  URL: http://svn.reactos.org/svn/reactos/branches/aicom-network- 
>  fixes/lib/drivers/ip/transport/tcp/tcp.c? 
>  rev=37247&r1=37246&r2=37247&view=diff
>  ====================================================================== 
>  ========
>  --- branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c  
>  [iso-8859-1] (original)
>  +++ branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c  
>  [iso-8859-1] Fri Nov  7 13:12:26 2008
>  @@ -283,8 +283,7 @@
>   }
>
>   VOID TCPFreeConnectionEndpoint( PCONNECTION_ENDPOINT Connection ) {
>  -    TI_DbgPrint(MAX_TRACE,("FIXME: Cancel all pending requests\n"));
>  -    /* XXX Cancel all pending requests */
>  +    TCPClose( Connection );
>       ExFreePool( Connection );
>   }
>
>