Re: [ros-dev] [ros-diffs] [akhaldi] 58438: [CMAKE] * Add "/nologo" to the MSVC resource compilation rule. Brought to you by Yu Pan (binsys {at} 163 dot com). CORE-6997 #resolve #comment Committed in r58438.

[Timo Kreuzer]

Oh did they finally fix rc?
Because this didn't work since 2005 up to WDK7.

Am 07.03.2013 17:22, schrieb akhaldi(a)svn.reactos.org:
>   Author: akhaldi
>  Date: Thu Mar  7 16:22:49 2013
>  New Revision: 58438
>
>  URL: http://svn.reactos.org/svn/reactos?rev=58438&view=rev
>  Log:
>  [CMAKE]
>  * Add "/nologo" to the MSVC resource compilation rule. Brought to you by Yu Pan
> (binsys {at} 163 dot com).
>  CORE-6997 #resolve #comment Committed in r58438.
>
>  Modified:
>       trunk/reactos/cmake/msvc.cmake
>
>  Modified: trunk/reactos/cmake/msvc.cmake
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=58438…
>  ==============================================================================
>  --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original)
>  +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Thu Mar  7 16:22:49 2013
>  @@ -57,7 +57,7 @@
>        # for VS builds we'll only have en-US in resource files
>        add_definitions(/DLANGUAGE_EN_US)
>    else()
>  -    set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> <FLAGS>
> <DEFINES> ${I18N_DEFS} /fo<OBJECT> <SOURCE>")
>  +    set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> /nologo <FLAGS>
> <DEFINES> ${I18N_DEFS} /fo<OBJECT> <SOURCE>")
>        set(CMAKE_ASM_COMPILE_OBJECT
>            "cl /nologo /X /I${REACTOS_SOURCE_DIR}/include/asm
> /I${REACTOS_BINARY_DIR}/include/asm <FLAGS> <DEFINES> /D__ASM__ /D_USE_ML /EP
> /c <SOURCE> > <OBJECT>.tmp"
>            "<CMAKE_ASM_COMPILER> /nologo /Cp /Fo<OBJECT> /c /Ta
> <OBJECT>.tmp")
>
>
>

[BinSys]

With VS2012 x86 Native Tools Command Prompt,cancomplete compilation,butcan not enter
thedesktop.


At 2013-03-08 17:00:52,"Timo Kreuzer" <timo.kreuzer(a)web.de> wrote: >Oh
did they finally fix rc? >Because this didn't work since 2005 up to WDK7. >
>Am 07.03.2013 17:22, schrieb akhaldi(a)svn.reactos.org: >> Author: akhaldi
>> Date: Thu Mar  7 16:22:49 2013 >> New Revision: 58438 >> >>
URL: http://svn.reactos.org/svn/reactos?rev=58438&view=rev >> Log: >>
[CMAKE] >> * Add "/nologo" to the MSVC resource compilation rule. Brought
to you by Yu Pan (binsys {at} 163 dot com). >> CORE-6997 #resolve #comment Committed
in r58438. >> >> Modified: >>      trunk/reactos/cmake/msvc.cmake
>> >> Modified: trunk/reactos/cmake/msvc.cmake >> URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=58438…
>> ==============================================================================
>> --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) >> +++
trunk/reactos/cmake/msvc.cmake [iso-8859-1] Thu Mar  7 16:22:49 2013 >> @@ -57,7
+57,7 @@ >>       # for VS builds we'll only have en-US in resource files
>>       add_definitions(/DLANGUAGE_EN_US) >>   else() >> -   
set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> <FLAGS> <DEFINES>
${I18N_DEFS} /fo<OBJECT> <SOURCE>") >> +   
set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> /nologo <FLAGS>
<DEFINES> ${I18N_DEFS} /fo<OBJECT> <SOURCE>") >>      
set(CMAKE_ASM_COMPILE_OBJECT >>           "cl /nologo /X
/I${REACTOS_SOURCE_DIR}/include/asm /I${REACTOS_BINARY_DIR}/include/asm <FLAGS>
<DEFINES> /D__ASM__ /D_USE_ML /EP /c <SOURCE> > <OBJECT>.tmp"
>>           "<CMAKE_ASM_COMPILER> /nologo /Cp /Fo<OBJECT> /c /Ta
<OBJECT>.tmp") >> >> >> > >
>_______________________________________________ >Ros-dev mailing list
&gt;Ros-dev(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-dev