RE: [weiden] 13639: 2. fixed GetVersionEx()

[Ge van Geldorp]

> From: [e-mail]
> fixed GetVersionEx()
>
> Updated files:
> trunk/reactos/lib/kernel32/misc/env.c

The part starting :/* append a reactos specific string to the szCSDVersion
string */" is wrong. You've just appended the ReactOS version string to the
existing szCSDVersion, but it should be added after the terminating null of
the existing szCSDVersion, i.e. "Service Pack 6\0ReactOS 0.3-SVN (Build
20050219-r13360)\0". This way, ReactOS unaware apps will just get the
standard CSDVersion (Service Pack 6), while ReactOS aware apps can get the
ReactOS version. Discussed on the mailing list
http://reactos.com:8080/archives/public/ros-dev/2004-December/001117.html
and followups.

Gé van Geldorp.

[Thomas Weidenmueller]

Ge van Geldorp wrote:
> The part starting :/* append a reactos specific string to the szCSDVersion
> string */" is wrong. You've just appended the ReactOS version string to the
> existing szCSDVersion, but it should be added after the terminating null of
> the existing szCSDVersion, i.e. "Service Pack 6\0ReactOS 0.3-SVN (Build
> 20050219-r13360)\0". This way, ReactOS unaware apps will just get the
> standard CSDVersion (Service Pack 6), while ReactOS aware apps can get the
> ReactOS version. Discussed on the mailing list
> http://reactos.com:8080/archives/public/ros-dev/2004-December/001117.html
> and followups.

Oh, I'm sorry, I wasn't aware of this document. I'll fix it when i get 
back home today.

Best Regards,
Thomas