Re: [ros-dev] [ros-diffs] [greatlrd] 25794: patch from Physicus, implement TOOLTIPS_NotifyFormat, it now retrurn the type of the string if it unicode or ansi. before it did not return any type at all. it did a heap crash from downloader mangers when

[Steven Edwards]

On 2/14/07, Saveliy Tretiakov <saveliyt(a)gmail.com> wrote:
>   Ged Murphy пишет:
> >   IIRC, Julliard stated that if test cases were
> > submitted along with the
> >  patch, he would accept code. 
>  No, not always. My rpc code with testcases was not accepted, because it
>  was from reactos. 
I think Alexandre has loosened his restrictions a bit.  If I recall
correctly you had a widl patch, he might be interested in some of them
now as he is having to do a bit of work on that code.

Thanks

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Saveliy Tretiakov]

Steven Edwards пишет:
>   I think Alexandre has loosened his restrictions a bit.
>  If I recall
>  correctly you had a widl patch, he might be interested in some of them
>  now as he is having to do a bit of work on that code.
>     
I don't have this code now, lost the patch.

[James Tabor]

Hi!
Dont get this wrong,,, I like you, okay?
Steven Edwards wrote:
>   On 2/14/07, Saveliy Tretiakov
> <saveliyt(a)gmail.com> wrote:
>  
> >  Ged Murphy пишет:
> >
> > >  IIRC, Julliard stated that if test cases were
> > > submitted along with the
> > > patch, he would accept code. 
> > No, not always. My rpc code with testcases was not accepted, because it
> > was from reactos. 
>  
>  
>  I think Alexandre has loosened his restrictions a bit.  If I recall
>  correctly you had a widl patch, he might be interested in some of them
>  now as he is having to do a bit of work on that code.
>  
>  Thanks
>   
We could have used the help from Wine during the audit. It could have help to build and
make
Code Weavers a good guy thing. Unit the code base that kind of group team work thingy.


Our code is still open to all groups for review. You dont need git to read it. At least we
did not
convert over to git and loose the original meta data (history info).

Currently we harvest code from Wine that helps ReactOS. Corporate warfare 101.

I'm still open to negotiations on this mater. We still can work together for the
common good. With 
one goal in mind.

Stop M$ rule.

Thanks,
James

[Thomas Weidenmueller]

>   Our code is still open to all groups for review. You
> dont need git to read it. At least we did not
>  convert over to git and loose the original meta data (history info). 
Just for the record: The entire history and all commits are still there,
they didn't lose the meta data by converting to git. But I agree, git is
not a good choice because there's no windows port (at least I don't know
one) and it takes ages and gigabytes of traffic to duplicate a git tree...

- Thomas

[Alex Ionescu]

Thomas Weidenmueller wrote:
>   But I agree, git is
>  not a good choice because there's no windows port 
Since the entire idea of git is to undermine Microsoft/Windows, I think
the Wine folks consider this a great thing. In RMS's perfect world,
there's no gcc, no git, no gimp and no gnu for Windows.

-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS

[Thomas Weidenmueller]

>   Since the entire idea of git is to undermine
> Microsoft/Windows, I think
>  the Wine folks consider this a great thing. In RMS's perfect world,
>  there's no gcc, no git, no gimp and no gnu for Windows. 
That's a rediculous claim. git does have a few advantages that
svn/cvs/... don't have, such as distributed repositories. But in my
opinion it has more disadvantages than advantages, especially the poor
usability. The fact that there's no windows port (yet) is more likely
due to it's usage of perl (and I guess ActivePerl has it's problems...).

- Thomas

[Alex Ionescu]

Thomas Weidenmueller wrote:
> >  Since the
> > entire idea of git is to undermine Microsoft/Windows, I think
> > the Wine folks consider this a great thing. In RMS's perfect world,
> > there's no gcc, no git, no gimp and no gnu for Windows. 
>  
>  
>  That's a rediculous claim. git does have a few advantages that
>  svn/cvs/... don't have, such as distributed repositories. But in my
>  opinion it has more disadvantages than advantages, especially the poor
>  usability. The fact that there's no windows port (yet) is more likely
>  due to it's usage of perl (and I guess ActivePerl has it's problems...).
>  
>  - Thomas
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>   
Sorry, I meant Wine, not git.

-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS

[Steven Edwards]

On 2/15/07, Alex Ionescu <ionucu(a)videotron.ca> wrote:
>   Sorry, I meant Wine, not git. 
Just to be clear on the way I see it, and I am not trying to speak for
Alexandre here, if you want to get a patch in to Wine, apply it to
your local Wine tree, test it and make sure it works on Linux and does
not break a test and or write a test if it has new functionality, then
submit it. The CVS gateway is still open and hes not, not committing
patches just because someone has worked on ReactOS in the past. If it
says the patch is from ReactOS he is likely to still reject it given
all of the noise regarding ReactOS but if you develop it in the Wine
tree, make it clear that its a clean-room implementation and follow
the normal Wine rules for submission, even non-git patches still can
get merged. He's not been rejecting patches from Thomas, Martin, Ge
and others who have worked on ROS in the past and I do not expect him
to start but until the SFLC audit of Wine is done (which is still
being worked on) he is going to reject patches that are developed
specifically for ReactOS. This is not that much of a change then what
was always the case even before the ReactOS audit because he would not
accept certain code that was effectively dead on POSIXish platforms.

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo