Re: [ros-svn] [hbirr] 15381: - Reference the file object in IopSecurityFile.

[Alex Ionescu]

hbirr(a)svn.reactos.com wrote:

>  - Reference the file object in IopSecurityFile.  
> - Don't set FO_DIRECT_DEVICE_OPEN in IoCreateStreamFileObject.  
> - Disabled the setting of IRP_NOCACHE, because vfat cannot handle cached and non cached
> requests for the same file.  
> - Set the correct device object in NtWriteFile.
>
>
>
>
>   
>  
Hi,

This change breaks usetup. As I said, IoCreateStreamFileObject must be 
left with the current hack intact.

Best regards,
Alex Ionescu

[Hartmut Birr]

Alex Ionescu wrote:

>   hbirr(a)svn.reactos.com wrote:
>
> >   - Reference the file object in IopSecurityFile. 
> > - Don't set
> >  FO_DIRECT_DEVICE_OPEN in IoCreateStreamFileObject.  - Disabled the
> >  setting of IRP_NOCACHE, because vfat cannot handle cached and non
> >  cached requests for the same file.  - Set the correct device object
> >  in NtWriteFile. 
>
>  Hi,
>
>  This change breaks usetup. As I said, IoCreateStreamFileObject must be
>  left with the current hack intact.
>
>  Best regards,
>  Alex Ionescu
>  
Without this changes, vfatfs does crash very often while parsing a
directory and if the directory is larger than one cluster. I see this
while compiling ros on ros. After a crash, chkdsk has many to do. Please
remove this hack immediately.

- Hartmut

[James Tabor]

Hartmut Birr wrote:
>   Alex Ionescu wrote:
>  
>  
> >  hbirr(a)svn.reactos.com wrote:
> >
> >
> > >  - Reference the file object in IopSecurityFile.  -
> > > Don't set
> > > FO_DIRECT_DEVICE_OPEN in IoCreateStreamFileObject.  - Disabled the
> > > setting of IRP_NOCACHE, because vfat cannot handle cached and non
> > > cached requests for the same file.  - Set the correct device object
> > > in NtWriteFile. 
> >
> > Hi,
> >
> > This change breaks usetup. As I said, IoCreateStreamFileObject must be
> > left with the current hack intact.
> >
> > Best regards,
> > Alex Ionescu
> >  
>  
>  Without this changes, vfatfs does crash very often while parsing a
>  directory and if the directory is larger than one cluster. I see this
>  while compiling ros on ros. After a crash, chkdsk has many to do. Please
>  remove this hack immediately.
>  
>  - Hartmut
>   
We need both usetup and a stable vfatfs. Building ros on ros is a big
part of our development testing. If that is broken!

So do we think the problem is in the vfatfs or in io/file.c?
James