Re: [ros-svn] [ion] 16811: - Fix debug header nonsense

[Hartmut Birr]

[e-mail] wrote:
> Fix debug header nonsense
> Fix some w32api definitions
> MSVC/PSDK Compatibility fixes.
> Clean up user32 headers for greater PCH usage.
>
> Added files:
> trunk/reactos/lib/user32/include/controls.h
> trunk/reactos/lib/user32/include/dde_private.h
> trunk/reactos/w32api/include/winnls32.h
>
> Updated files:
> trunk/reactos/apps/utils/ps/ps.c
> trunk/reactos/drivers/dd/mpu401/settings.c
> trunk/reactos/include/reactos/debug.h
> trunk/reactos/include/wine/debug.h
> trunk/reactos/lib/ntdll/inc/ntdll.h
> trunk/reactos/lib/user32/controls/button.c
> trunk/reactos/lib/user32/controls/combo.c
> trunk/reactos/lib/user32/controls/edit.c
> trunk/reactos/lib/user32/controls/icontitle.c
> trunk/reactos/lib/user32/controls/listbox.c
> trunk/reactos/lib/user32/controls/scrollbar.c
> trunk/reactos/lib/user32/include/user32.h
> trunk/reactos/lib/user32/include/user32p.h
> trunk/reactos/lib/user32/misc/dde.c
> trunk/reactos/lib/user32/misc/ddeclient.c
> trunk/reactos/lib/user32/misc/ddeserver.c
> trunk/reactos/lib/user32/misc/display.c
> trunk/reactos/lib/user32/misc/dllmain.c
> trunk/reactos/lib/user32/misc/exticon.c
> trunk/reactos/lib/user32/misc/object.c
> trunk/reactos/lib/user32/misc/stubs.c
> trunk/reactos/lib/user32/windows/bitmap.c
> trunk/reactos/lib/user32/windows/clipboard.c
> trunk/reactos/lib/user32/windows/cursor.c
> trunk/reactos/lib/user32/windows/defwnd.c
> trunk/reactos/lib/user32/windows/dialog.c
> trunk/reactos/lib/user32/windows/draw.c
> trunk/reactos/lib/user32/windows/font.c
> trunk/reactos/lib/user32/windows/hook.c
> trunk/reactos/lib/user32/windows/icon.c
> trunk/reactos/lib/user32/windows/input.c
> trunk/reactos/lib/user32/windows/mdi.c
> trunk/reactos/lib/user32/windows/menu.c
> trunk/reactos/lib/user32/windows/message.c
> trunk/reactos/lib/user32/windows/messagebox.c
> trunk/reactos/lib/user32/windows/nonclient.c
> trunk/reactos/lib/user32/windows/paint.c
> trunk/reactos/lib/user32/windows/window.c
> trunk/reactos/w32api/include/winuser.h
>
> Deleted files:
> trunk/reactos/lib/user32/controls/controls.h
> trunk/reactos/lib/user32/include/debug.h
> trunk/reactos/lib/user32/misc/dde_private.h
>
> Ros-svn mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-svn

Please revert the changes in include/wine/debug.h. Your changes enables
the TRACE and WARN statements for all wine dlls. The debug messages are
no longer useful, because the output is flooded with thausends of
unwanted messages.

- Hartmut

[Alex Ionescu]

Hartmut Birr wrote:
> [e-mail] wrote:
>
> lease revert the changes in include/wine/debug.h. Your changes enables
> the TRACE and WARN statements for all wine dlls. The debug messages are
> no longer useful, because the output is flooded with thausends of
> unwanted messages.
> Hartmut

Hi,

Sorry, you are right, I forgot that WINE DLLs use YDEBUG instead of NDEBUG.

Best regards,
Alex Ionescu