Re: [ros-dev] [ros-diffs] [tkreuzer] 58193: [SAL.H] "Implement" all used annotations [XDK/DDK] Add missing annotations, move some prototypes to more appropriate headers [NDK] Fix a number of annotations [NDK] Use SAL2 dummy...

[Timo Kreuzer]

Addition:
I fixed the *VERIFY macros, so that they actually work. Instead of 
defining them to the ASSERT macros, we now define the ASSERT macros to 
VERIFY, additionally casting to void to get rid of the errors.

I also modified the NT_ASSERT / NT_VERIFY macros a bit, so that on GCC 
builds they are closer to what MSVC builds generate.

I'd like to encourage to make use of NT_ASSERT.
If you don't know the differences to a "normal" ASSERT, please check out 
this excellent article: http://www.osronline.com/article.cfm?article=474

Timo

Am 19.01.2013 22:49, schrieb tkreuzer(a)svn.reactos.org:
>   Author: tkreuzer
>  Date: Sat Jan 19 21:49:12 2013
>  New Revision: 58193
>
>  URL: http://svn.reactos.org/svn/reactos?rev=58193&view=rev
>  Log:
>  [SAL.H] "Implement" all used annotations
>  [XDK/DDK] Add missing annotations, move some prototypes to more appropriate headers
>  [NDK] Fix a number of annotations
>  [NDK] Use SAL2 dummys from umtypes as well
>
>  Modified:
>       trunk/reactos/include/ddk/ntifs.h
>       trunk/reactos/include/ddk/wdm.h
>       trunk/reactos/include/ndk/exfuncs.h
>       trunk/reactos/include/ndk/kefuncs.h
>       trunk/reactos/include/ndk/mmfuncs.h
>       trunk/reactos/include/ndk/obfuncs.h
>       trunk/reactos/include/ndk/rtlfuncs.h
>       trunk/reactos/include/ndk/sefuncs.h
>       trunk/reactos/include/ndk/setypes.h
>       trunk/reactos/include/ndk/umtypes.h
>       trunk/reactos/include/psdk/sal.h
>       trunk/reactos/include/xdk/mmfuncs.h
>       trunk/reactos/include/xdk/ntifs.template.h
>       trunk/reactos/include/xdk/obfuncs.h
>       trunk/reactos/include/xdk/rtlfuncs.h
>       trunk/reactos/include/xdk/zwfuncs.h
>
>  [This mail would be too long, it was shortened to contain the URLs only.]
>
>  Modified: trunk/reactos/include/ddk/ntifs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=58…
>
>  Modified: trunk/reactos/include/ddk/wdm.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=5819…
>
>  Modified: trunk/reactos/include/ndk/exfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/exfuncs.h?rev=…
>
>  Modified: trunk/reactos/include/ndk/kefuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/kefuncs.h?rev=…
>
>  Modified: trunk/reactos/include/ndk/mmfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/mmfuncs.h?rev=…
>
>  Modified: trunk/reactos/include/ndk/obfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/obfuncs.h?rev=…
>
>  Modified: trunk/reactos/include/ndk/rtlfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/rtlfuncs.h?rev…
>
>  Modified: trunk/reactos/include/ndk/sefuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/sefuncs.h?rev=…
>
>  Modified: trunk/reactos/include/ndk/setypes.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/setypes.h?rev=…
>
>  Modified: trunk/reactos/include/ndk/umtypes.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/umtypes.h?rev=…
>
>  Modified: trunk/reactos/include/psdk/sal.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/sal.h?rev=581…
>
>  Modified: trunk/reactos/include/xdk/mmfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/mmfuncs.h?rev=…
>
>  Modified: trunk/reactos/include/xdk/ntifs.template.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/ntifs.template…
>
>  Modified: trunk/reactos/include/xdk/obfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/obfuncs.h?rev=…
>
>  Modified: trunk/reactos/include/xdk/rtlfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/rtlfuncs.h?rev…
>
>  Modified: trunk/reactos/include/xdk/zwfuncs.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/zwfuncs.h?rev=…
>
>
>

[Aleksey Bragin]

This is a very good thing to include into ReactOS Development Guidelines.

Regards,
Aleksey Bragin

On 20.01.2013 4:03, Timo Kreuzer wrote:
>  
>  Addition:
>  I fixed the *VERIFY macros, so that they actually work. Instead of 
>  defining them to the ASSERT macros, we now define the ASSERT macros to 
>  VERIFY, additionally casting to void to get rid of the errors.
>
>  I also modified the NT_ASSERT / NT_VERIFY macros a bit, so that on GCC 
>  builds they are closer to what MSVC builds generate.
>
>  I'd like to encourage to make use of NT_ASSERT.
>  If you don't know the differences to a "normal" ASSERT, please check 
>  out this excellent article: 
>  http://www.osronline.com/article.cfm?article=474
>
>  Timo
>
>  Am 19.01.2013 22:49, schrieb tkreuzer(a)svn.reactos.org:
> > Author: tkreuzer
> > Date: Sat Jan 19 21:49:12 2013
> > New Revision: 58193
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=58193&view=rev
> > Log:
> > [SAL.H] "Implement" all used annotations
> > [XDK/DDK] Add missing annotations, move some prototypes to more 
> > appropriate headers
> > [NDK] Fix a number of annotations
> > [NDK] Use SAL2 dummys from umtypes as well