Re: [ros-dev] [ros-diffs] [tkreuzer] 65390: [WIN32SS] if (BooleanValue == TRUE) -> if (!BooleanValue) Patch by Love Nystrom CORE-8799
obviously it was meant to be "if (BooleanValue == TRUE) -> if (BooleanValue)"
Am 13.11.2014 11:31, schrieb tkreuzer@svn.reactos.org:
Author: tkreuzer Date: Thu Nov 13 10:31:45 2014 New Revision: 65390
URL: http://svn.reactos.org/svn/reactos?rev=65390&view=rev Log: [WIN32SS] if (BooleanValue == TRUE) -> if (!BooleanValue) Patch by Love Nystrom CORE-8799
Modified: trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c trunk/reactos/win32ss/drivers/displays/vga/main/enable.c trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c trunk/reactos/win32ss/gdi/dib/floodfill.c trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c trunk/reactos/win32ss/user/ntuser/hotkey.c trunk/reactos/win32ss/user/ntuser/message.c trunk/reactos/win32ss/user/ntuser/msgqueue.c trunk/reactos/win32ss/user/user32/controls/appswitch.c trunk/reactos/win32ss/user/user32/misc/desktop.c trunk/reactos/win32ss/user/user32/misc/winsta.c trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c trunk/reactos/win32ss/user/winsrv/usersrv/register.c
Modified: trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/fr... ============================================================================== --- trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -38,7 +38,7 @@ { PPDEV ppdev = (PPDEV)dhpdev;
if (ppdev->bDDInitialized == TRUE)
if (ppdev->bDDInitialized)@@ -237,7 +237,7 @@ { ppdev->pvmList = pvmList;
if ( bDDrawHeap == TRUE)
if (bDDrawHeap)Modified: trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/fr... ============================================================================== --- trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -110,7 +110,7 @@ VOID FASTCALL IntShowMousePointer(PPDEV ppdev, SURFOBJ *DestSurface) {
- if (ppdev->PointerAttributes.Enable == TRUE)
- if (ppdev->PointerAttributes.Enable) { return; }
Modified: trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/fr... ============================================================================== --- trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -38,7 +38,7 @@ { PPDEV ppdev = (PPDEV)dhpdev;
if (ppdev->bDDInitialized == TRUE)
if (ppdev->bDDInitialized)@@ -237,7 +237,7 @@ { ppdev->pvmList = pvmList;
if ( bDDrawHeap == TRUE)
if (bDDrawHeap)Modified: trunk/reactos/win32ss/drivers/displays/vga/main/enable.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/vg... ============================================================================== --- trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -302,7 +302,7 @@ PPDEV ppdev = (PPDEV)DPev; ULONG returnedDataLength;
- if(Enable==TRUE)
- if (Enable) { /* Reenable our graphics mode */ if (!InitPointer(ppdev))
Modified: trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/vg... ============================================================================== --- trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -560,7 +560,7 @@ pb++; }
if (edgePixel == TRUE)
if (edgePixel) { b1 = *pb; if(b1 != trans) vgaPutPixel(x2, j, b1);Modified: trunk/reactos/win32ss/gdi/dib/floodfill.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/dib/floodfill.c... ============================================================================== --- trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -61,7 +61,7 @@ { if (RECTL_bPointInRect(DstRect,x,y)) {
- if (isSurf == TRUE &&
- if (isSurf && DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y) != Color) { return;
Modified: trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/gdie... ============================================================================== --- trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -1837,7 +1837,7 @@ { /* Free it */ Return = NtGdiDdDeleteDirectDrawObject((HANDLE)pDirectDrawGlobal->hDD);
if (Return == TRUE)
if (Return) { pDirectDrawGlobal->hDD = 0; }@@ -1852,7 +1852,7 @@ { /* Delete the object */ Return = NtGdiDdDeleteDirectDrawObject(ghDirectDraw);
if (Return == TRUE)
if (Return) { ghDirectDraw = 0; }Modified: trunk/reactos/win32ss/user/ntuser/hotkey.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/hotkey.... ============================================================================== --- trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -212,7 +212,7 @@ if (!bIsDown) { /* WIN and F12 keys are not hardcoded here. See comments on top of this file. */
if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive == TRUE)
if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive) { pWnd = ValidateHwndNoErr(InputWindowStation->ShellWindow); if (pWnd)Modified: trunk/reactos/win32ss/user/ntuser/message.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/message... ============================================================================== --- trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -2087,7 +2087,7 @@
UserLeave();
- if (Ret == TRUE)
- if (Ret) { _SEH2_TRY {
Modified: trunk/reactos/win32ss/user/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/msgqueu... ============================================================================== --- trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -805,7 +805,7 @@ *Message->Result = Result; }
- if (Message->HasPackedLParam == TRUE)
- if (Message->HasPackedLParam) { if (Message->Msg.lParam) ExFreePool((PVOID)Message->Msg.lParam);
@@ -887,7 +887,7 @@ KeSetEvent(SentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); }
if (SentMessage->HasPackedLParam == TRUE)
if (SentMessage->HasPackedLParam) { if (SentMessage->Msg.lParam) ExFreePool((PVOID)SentMessage->Msg.lParam);@@ -1966,7 +1966,7 @@ KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); }
if (CurrentSentMessage->HasPackedLParam == TRUE)
if (CurrentSentMessage->HasPackedLParam) { if (CurrentSentMessage->Msg.lParam) ExFreePool((PVOID)CurrentSentMessage->Msg.lParam);@@ -1998,7 +1998,7 @@ KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); }
if (CurrentSentMessage->HasPackedLParam == TRUE)
if (CurrentSentMessage->HasPackedLParam) { if (CurrentSentMessage->Msg.lParam) ExFreePool((PVOID)CurrentSentMessage->Msg.lParam);Modified: trunk/reactos/win32ss/user/user32/controls/appswitch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/control... ============================================================================== --- trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -522,7 +522,7 @@ return TRUE;
case WM_SHOWWINDOW:
if (wParam == TRUE)
if (wParam) { PrepareWindow(); ati = (PALTTABINFO)GetWindowLongPtrW(hWnd, 0);Modified: trunk/reactos/win32ss/user/user32/misc/desktop.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/de... ============================================================================== --- trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -610,7 +610,7 @@ GetProcessWindowStation(), 0);
- if( fInherit == TRUE )
- if( fInherit ) { ObjectAttributes.Attributes |= OBJ_INHERIT; }
Modified: trunk/reactos/win32ss/user/user32/misc/winsta.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/wi... ============================================================================== --- trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -372,7 +372,7 @@ hWindowStationsDir, 0);
- if( fInherit == TRUE )
- if( fInherit ) { ObjectAttributes.Attributes |= OBJ_INHERIT; }
Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv/... ============================================================================== --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -1784,7 +1784,7 @@ static VOID Copy(PGUI_CONSOLE_DATA GuiData) {
- if (OpenClipboard(GuiData->hWindow) == TRUE)
- if (OpenClipboard(GuiData->hWindow)) { PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer;
@@ -1814,7 +1814,7 @@ static VOID Paste(PGUI_CONSOLE_DATA GuiData) {
- if (OpenClipboard(GuiData->hWindow) == TRUE)
- if (OpenClipboard(GuiData->hWindow)) { PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer;
Modified: trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv_... ============================================================================== --- trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -1336,7 +1336,7 @@ static VOID GuiConsoleCopy(PGUI_CONSOLE_DATA GuiData) {
- if (OpenClipboard(GuiData->hWindow) == TRUE)
- if (OpenClipboard(GuiData->hWindow)) { PCONSOLE Console = GuiData->Console; PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console);
@@ -1364,7 +1364,7 @@ static VOID GuiConsolePaste(PGUI_CONSOLE_DATA GuiData) {
- if (OpenClipboard(GuiData->hWindow) == TRUE)
- if (OpenClipboard(GuiData->hWindow)) { PCONSOLE Console = GuiData->Console; PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console);
Modified: trunk/reactos/win32ss/user/winsrv/usersrv/register.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/usersrv... ============================================================================== --- trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] Thu Nov 13 10:31:45 2014 @@ -53,7 +53,7 @@ { PUSER_REGISTER_SERVICES_PROCESS RegisterServicesProcessRequest = &((PUSER_API_MESSAGE)ApiMessage)->Data.RegisterServicesProcessRequest;
- if (ServicesProcessIdValid == TRUE)
- if (ServicesProcessIdValid) { /* Only accept a single call */ return STATUS_INVALID_PARAMETER;
-
Timo Kreuzer