Re: [ros-cvs] CVS Update: reactos

[Filip Navara]

Ge van Geldorp wrote:
> CVSROOT:	/CVS/ReactOS
> Module name:	reactos
> Repository:	reactos/subsys/win32k/objects/
> Changes by:	[e-mail]	04/12/17 09:40:37
>
> Modified files:
>    reactos/subsys/win32k/objects/: text.c
>
> Log message:
>    Pass parameters in correct order

You can't just remove the code for negative font heights. Negative sizes 
aren't implemented correctly (see MSDN for CreateFont), but they still 
need to be handled.

- Filip

[Ge van Geldorp]

> From: Filip Navara
> > Log message:
> >    Pass parameters in correct order
>
> You can't just remove the code for negative font heights. 
> Negative sizes aren't implemented correctly (see MSDN for
> CreateFont), but they still need to be handled.

Not sure what you mean, the code for negative font heights is still there:

(TextObj->logfont.lfHeight < 0 ?
 - TextObj->logfont.lfHeight :
 TextObj->logfont.lfHeight == 0 ? 11 : TextObj->logfont.lfHeight)

Gé van Geldorp