New subject: [ros-diffs] [cwittich] 27397: ZeroMemory the correct amount of bytes

5 Jul 2007

I think those changes are incorrect, because you're effectively  
zeroing sizeof(void *) instead of zeroing sizeof(PORT_DEVICE_EXTENSION).

WBR,
Aleksey Bragin.

On Jul 5, 2007, at 5:24 AM, cwittich(a)svn.reactos.org wrote:

...
  Author: cwittich
 Date: Thu Jul  5 05:24:57 2007
 New Revision: 27397

 URL: http://svn.reactos.org/svn/reactos?rev=27397&view=rev
 Log:
 ZeroMemory the correct amount of bytes

 Modified:
     trunk/reactos/drivers/input/kbdclass/kbdclass.c

 Modified: trunk/reactos/drivers/input/kbdclass/kbdclass.c
 URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/ 
 kbdclass/kbdclass.c?rev=27397&r1=27396&r2=27397&view=diff
 ====================================================================== 
 ========
 --- trunk/reactos/drivers/input/kbdclass/kbdclass.c (original)
 +++ trunk/reactos/drivers/input/kbdclass/kbdclass.c Thu Jul  5  
 05:24:57 2007
 @@ -695,7 +695,7 @@
  	}

  	DeviceExtension = (PPORT_DEVICE_EXTENSION)Fdo->DeviceExtension;
 -	RtlZeroMemory(DeviceExtension, sizeof(CLASS_DEVICE_EXTENSION));
 +	RtlZeroMemory(DeviceExtension, sizeof(PPORT_DEVICE_EXTENSION));
  	DeviceExtension->Common.IsClassDO = FALSE;
  	DeviceExtension->DeviceObject = Fdo;
  	DeviceExtension->PnpState = dsStopped;

Re: [ros-dev] [ros-diffs] [cwittich] 27397: ZeroMemory the correct amount of bytes