Re: [ros-svn] [ekohl] 18383: First shot at CreateServiceW. It crashes due to a bug (aka missing feature) in widl. = ROS BUILD FAILED

[Gge]

[e-mail] wrote:
> First shot at CreateServiceW. It crashes due to a bug (aka missing feature) in widl. I'm going to fix it as soon as possible.
>
> Updated files:
> trunk/reactos/include/idl/svcctl.idl
> trunk/reactos/lib/advapi32/service/scm.c
> trunk/reactos/subsys/system/services/database.c
> trunk/reactos/subsys/system/services/rpcserver.c
> trunk/reactos/subsys/system/services/services.c
> trunk/reactos/subsys/system/services/services.h

Hello,

This change brokes Ros - It fails to build with the following errors :

[CC]       lib\advapi32\service\eventlog.c
[CC]       lib\advapi32\service\scm.c
lib\advapi32\service\scm.c: In function `CreateServiceW':
lib\advapi32\service\scm.c:271: warning: implicit declaration of 
function `ScmrCreateServiceW'
mingw32-make: *** [obj-i386\lib\advapi32\service\scm.o] Error 1

R18382 builds fine

Regards
Gge

[Christoph von Wittich]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> This change brokes Ros - It fails to build with the following errors :

Hi!
> This change brokes Ros - It fails to build with the following errors :
> [CC]       lib\advapi32\service\eventlog.c
> [CC]       lib\advapi32\service\scm.c
> lib\advapi32\service\scm.c: In function `CreateServiceW':
> lib\advapi32\service\scm.c:271: warning: implicit declaration of
> function `ScmrCreateServiceW'
> mingw32-make: *** [obj-i386\lib\advapi32\service\scm.o] Error 1

Works fine for me... (r18406)

mingw32-make advapi32
[PCH]      obj-i386\lib\advapi32\advapi32.h.gch
[CC]       lib\advapi32\crypt\crypt.c
[CC]       lib\advapi32\crypt\crypt_des.c
[CC]       lib\advapi32\crypt\crypt_lmhash.c
[CC]       lib\advapi32\crypt\crypt_md4.c
[CC]       lib\advapi32\crypt\crypt_md5.c
[CC]       lib\advapi32\crypt\crypt_sha.c
[CC]       lib\advapi32\misc\dllmain.c
[CC]       lib\advapi32\misc\hwprofiles.c
[CC]       lib\advapi32\misc\logon.c
[CC]       lib\advapi32\misc\shutdown.c
[CC]       lib\advapi32\misc\sysfunc.c
[CC]       lib\advapi32\reg\reg.c
[CC]       lib\advapi32\sec\ac.c
[CC]       lib\advapi32\sec\audit.c
[CC]       lib\advapi32\sec\lsa.c
[CC]       lib\advapi32\sec\misc.c
[CC]       lib\advapi32\sec\sec.c
[CC]       lib\advapi32\sec\sid.c
[CC]       lib\advapi32\sec\trustee.c
[CC]       lib\advapi32\service\eventlog.c
[CC]       lib\advapi32\service\scm.c
[CC]       lib\advapi32\service\sctrl.c
[CC]       lib\advapi32\service\undoc.c
[CC]       lib\advapi32\token\privilege.c
[CC]       lib\advapi32\token\token.c
[WRC]      obj-i386\lib\advapi32\advapi32.coff
[LD]       output-i386\lib\advapi32\advapi32.dll
[RSYM]     output-i386\lib\advapi32\advapi32.dll

Regards
Christoph von Wittich
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (MingW32)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFDS6ed0ADPczu7wMoRAlZEAKCSCmorjtYh8LqsnyjJm4NE0EV/qgCcCEtr
> 3sqButZojkdGK9UwLXWka3w=
> =aNyU
> -----END PGP SIGNATURE-----

[Brandon Turner]

I think you need to do a make depends

Brandon

Christoph von Wittich wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> > This change brokes Ros - It fails to build with the following errors :
>
> Hi!
> > This change brokes Ros - It fails to build with the following errors :
> > [CC]       lib\advapi32\service\eventlog.c
> > [CC]       lib\advapi32\service\scm.c
> > lib\advapi32\service\scm.c: In function `CreateServiceW':
> > lib\advapi32\service\scm.c:271: warning: implicit declaration of
> > function `ScmrCreateServiceW'
> > mingw32-make: *** [obj-i386\lib\advapi32\service\scm.o] Error 1
>
> Works fine for me... (r18406)
>
> mingw32-make advapi32
> [PCH]      obj-i386\lib\advapi32\advapi32.h.gch
> [CC]       lib\advapi32\crypt\crypt.c
> [CC]       lib\advapi32\crypt\crypt_des.c
> [CC]       lib\advapi32\crypt\crypt_lmhash.c
> [CC]       lib\advapi32\crypt\crypt_md4.c
> [CC]       lib\advapi32\crypt\crypt_md5.c
> [CC]       lib\advapi32\crypt\crypt_sha.c
> [CC]       lib\advapi32\misc\dllmain.c
> [CC]       lib\advapi32\misc\hwprofiles.c
> [CC]       lib\advapi32\misc\logon.c
> [CC]       lib\advapi32\misc\shutdown.c
> [CC]       lib\advapi32\misc\sysfunc.c
> [CC]       lib\advapi32\reg\reg.c
> [CC]       lib\advapi32\sec\ac.c
> [CC]       lib\advapi32\sec\audit.c
> [CC]       lib\advapi32\sec\lsa.c
> [CC]       lib\advapi32\sec\misc.c
> [CC]       lib\advapi32\sec\sec.c
> [CC]       lib\advapi32\sec\sid.c
> [CC]       lib\advapi32\sec\trustee.c
> [CC]       lib\advapi32\service\eventlog.c
> [CC]       lib\advapi32\service\scm.c
> [CC]       lib\advapi32\service\sctrl.c
> [CC]       lib\advapi32\service\undoc.c
> [CC]       lib\advapi32\token\privilege.c
> [CC]       lib\advapi32\token\token.c
> [WRC]      obj-i386\lib\advapi32\advapi32.coff
> [LD]       output-i386\lib\advapi32\advapi32.dll
> [RSYM]     output-i386\lib\advapi32\advapi32.dll
>
> Regards
> Christoph von Wittich
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (MingW32)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFDS6ed0ADPczu7wMoRAlZEAKCSCmorjtYh8LqsnyjJm4NE0EV/qgCcCEtr
> 3sqButZojkdGK9UwLXWka3w=
> =aNyU
> -----END PGP SIGNATURE-----
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Gunnar Dalsnes]

delete all non-svn files under lib\advapi32. that did it for me

G.

Brandon Turner wrote:
> I think you need to do a make depends
>
> Brandon
>
> Christoph von Wittich wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > > This change brokes Ros - It fails to build with the following errors :
> >
> > Hi!
> > > This change brokes Ros - It fails to build with the following errors :
> > > [CC]       lib\advapi32\service\eventlog.c
> > > [CC]       lib\advapi32\service\scm.c
> > > lib\advapi32\service\scm.c: In function `CreateServiceW':
> > > lib\advapi32\service\scm.c:271: warning: implicit declaration of
> > > function `ScmrCreateServiceW'
> > > mingw32-make: *** [obj-i386\lib\advapi32\service\scm.o] Error 1
> >
> > Works fine for me... (r18406)
> >
> > mingw32-make advapi32
> > [PCH]      obj-i386\lib\advapi32\advapi32.h.gch
> > [CC]       lib\advapi32\crypt\crypt.c
> > [CC]       lib\advapi32\crypt\crypt_des.c
> > [CC]       lib\advapi32\crypt\crypt_lmhash.c
> > [CC]       lib\advapi32\crypt\crypt_md4.c
> > [CC]       lib\advapi32\crypt\crypt_md5.c
> > [CC]       lib\advapi32\crypt\crypt_sha.c
> > [CC]       lib\advapi32\misc\dllmain.c
> > [CC]       lib\advapi32\misc\hwprofiles.c
> > [CC]       lib\advapi32\misc\logon.c
> > [CC]       lib\advapi32\misc\shutdown.c
> > [CC]       lib\advapi32\misc\sysfunc.c
> > [CC]       lib\advapi32\reg\reg.c
> > [CC]       lib\advapi32\sec\ac.c
> > [CC]       lib\advapi32\sec\audit.c
> > [CC]       lib\advapi32\sec\lsa.c
> > [CC]       lib\advapi32\sec\misc.c
> > [CC]       lib\advapi32\sec\sec.c
> > [CC]       lib\advapi32\sec\sid.c
> > [CC]       lib\advapi32\sec\trustee.c
> > [CC]       lib\advapi32\service\eventlog.c
> > [CC]       lib\advapi32\service\scm.c
> > [CC]       lib\advapi32\service\sctrl.c
> > [CC]       lib\advapi32\service\undoc.c
> > [CC]       lib\advapi32\token\privilege.c
> > [CC]       lib\advapi32\token\token.c
> > [WRC]      obj-i386\lib\advapi32\advapi32.coff
> > [LD]       output-i386\lib\advapi32\advapi32.dll
> > [RSYM]     output-i386\lib\advapi32\advapi32.dll
> >
> > Regards
> > Christoph von Wittich
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.1 (MingW32)
> > Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
> >
> > iD8DBQFDS6ed0ADPczu7wMoRAlZEAKCSCmorjtYh8LqsnyjJm4NE0EV/qgCcCEtr
> > 3sqButZojkdGK9UwLXWka3w=
> > =aNyU
> > -----END PGP SIGNATURE-----
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Gge]

Gunnar Dalsnes wrote:
> delete all non-svn files under lib\advapi32. that did it for me
>
> G.
>
> Brandon Turner wrote:
> > I think you need to do a make depends
> >
> > Brandon
> >
> > Christoph von Wittich wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > > > This change brokes Ros - It fails to build with the following errors :
> > >
> > > Hi!
> > > > This change brokes Ros - It fails to build with the following errors :
> > > > [CC]       lib\advapi32\service\eventlog.c
> > > > [CC]       lib\advapi32\service\scm.c
> > > > lib\advapi32\service\scm.c: In function `CreateServiceW':
> > > > lib\advapi32\service\scm.c:271: warning: implicit declaration of
> > > > function `ScmrCreateServiceW'
> > > > mingw32-make: *** [obj-i386\lib\advapi32\service\scm.o] Error 1
> > >
> > > Works fine for me... (r18406)
> > >
> > > mingw32-make advapi32
> > > [PCH]      obj-i386\lib\advapi32\advapi32.h.gch
> > > [CC]       lib\advapi32\crypt\crypt.c
> > > [CC]       lib\advapi32\crypt\crypt_des.c
> > > [CC]       lib\advapi32\crypt\crypt_lmhash.c
> > > [CC]       lib\advapi32\crypt\crypt_md4.c
> > > [CC]       lib\advapi32\crypt\crypt_md5.c
> > > [CC]       lib\advapi32\crypt\crypt_sha.c
> > > [CC]       lib\advapi32\misc\dllmain.c
> > > [CC]       lib\advapi32\misc\hwprofiles.c
> > > [CC]       lib\advapi32\misc\logon.c
> > > [CC]       lib\advapi32\misc\shutdown.c
> > > [CC]       lib\advapi32\misc\sysfunc.c
> > > [CC]       lib\advapi32\reg\reg.c
> > > [CC]       lib\advapi32\sec\ac.c
> > > [CC]       lib\advapi32\sec\audit.c
> > > [CC]       lib\advapi32\sec\lsa.c
> > > [CC]       lib\advapi32\sec\misc.c
> > > [CC]       lib\advapi32\sec\sec.c
> > > [CC]       lib\advapi32\sec\sid.c
> > > [CC]       lib\advapi32\sec\trustee.c
> > > [CC]       lib\advapi32\service\eventlog.c
> > > [CC]       lib\advapi32\service\scm.c
> > > [CC]       lib\advapi32\service\sctrl.c
> > > [CC]       lib\advapi32\service\undoc.c
> > > [CC]       lib\advapi32\token\privilege.c
> > > [CC]       lib\advapi32\token\token.c
> > > [WRC]      obj-i386\lib\advapi32\advapi32.coff
> > > [LD]       output-i386\lib\advapi32\advapi32.dll
> > > [RSYM]     output-i386\lib\advapi32\advapi32.dll
> > >
> > > Regards
> > > Christoph von Wittich

I deleted the lib/directory , svn update and make ... Still the same 
error with 18407

Gge