Re: [ros-dev] [ros-diffs] [greatlrd] 22614: fixing link for explorer and regedit thanks apal for the patch see bug 1626

[Ged Murphy]

IMO, this change is wrong and should be reverted.
The start menu should be searching in %systemroot% as well as 
%systemroot%/system32.
We used to do this, and there is a regression somewhere.

Ged.

[e-mail] wrote:
> Author: greatlrd
> Date: Mon Jun 26 02:34:49 2006
> New Revision: 22614
>
> URL: http://svn.reactos.org/svn/reactos?rev=22614&view=rev
> Log:
> fixing link for explorer and regedit thanks apal for the patch see bug 1626
>
> Modified:
>     trunk/reactos/dll/win32/syssetup/install.c
>
> Modified: trunk/reactos/dll/win32/syssetup/install.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/install....
> ==============================================================================
> --- trunk/reactos/dll/win32/syssetup/install.c (original)
> +++ trunk/reactos/dll/win32/syssetup/install.c Mon Jun 26 02:34:49 2006
> @@ -424,8 +424,8 @@
>    CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("Calculator.lnk"), _T("calc.exe"), IDS_CMT_CALC);
>    CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("Command Prompt.lnk"), _T("cmd.exe"), IDS_CMT_CMD);
>      CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("Notepad.lnk"), _T("notepad.exe"), IDS_CMT_NOTEPAD);
> CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("ReactOS Explorer.lnk"), _T("explorer.exe"), IDS_CMT_EXPLORER);
> CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("Regedit.lnk"), _T("regedit.exe"), IDS_CMT_REGEDIT);
> CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("ReactOS Explorer.lnk"), _T("..\explorer.exe"), IDS_CMT_EXPLORER);
> CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("Regedit.lnk"), _T("..\regedit.exe"), IDS_CMT_REGEDIT);
> CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("WordPad.lnk"), _T("wordpad.exe"), IDS_CMT_WORDPAD);
> CreateShortcut(CSIDL_PROGRAMS, sAccessories, _T("SnapShot.lnk"), _T("screenshot.exe"), IDS_CMT_SCREENSHOT);
> }

[Thomas Weidenmueller]

Ged Murphy wrote:
> IMO, this change is wrong and should be reverted.

Yes, this change is wrong and should be reverted. Search paths aren't
correctly supported at the moment, that's why it doesn't always find the
executables...

- Thomas