[ros-svn] [sgasiorek] 20238: "MSVCRT memcpy behaves like memmove for overlapping moves"

[WaxDragon]

This breaks mingw32-make from the RosBE 0.1

WD
--
<Russell> argh
<Russell> iterator shenanigans :/

[WaxDragon]

Well, maybe not.  Now that I double check, reverting this change
didn't seem to fix it.  It's between 20218 and 20238.

On 12/18/05, WaxDragon [e-mail] wrote:
> This breaks mingw32-make from the RosBE 0.1
> WD
>
> <Russell> argh
> <Russell> iterator shenanigans :/

--
<Russell> argh
<Russell> iterator shenanigans :/

[Hartmut Birr]

WaxDragon wrote:
> Well, maybe not.  Now that I double check, reverting this change
> didn't seem to fix it.  It's between 20218 and 20238.

Do you see something like this:

Unhandled exception
ExceptionCode:    c0000005
Faulting Address:       2c
Address:            41028a   H:\mingw\mingw32\bin\as.exe
CS:EIP 1b:41028a
DS 23 ES 23 FS 3b GS 0
EAX: 0000002c   EBX: 0000002c   ECX: 00000000
EDX: 00010001   EBP: 006cfed8   ESI: 007e20e1   ESP: 006cfec0
EDI: 007e21a8   EFLAGS: 00010206
Frames:
     400000+35fd       H:\mingw\mingw32\bin\as.exe
     400000+1092       H:\mingw\mingw32\bin\as.exe
     400000+1133       H:\mingw\mingw32\bin\as.exe
   7c800000+1b202      G:\ReactOS\system32\KERNEL32.dll

- Hartmut

[WaxDragon]

Well, I was seeing NTDLL, then a bunch of mingw32-make calls.  It was
a usermode exception.  Doing some more testing, it is 20238 that is
causing the problem.

On 12/18/05, Hartmut Birr [e-mail] wrote:
> WaxDragon wrote:
> > Well, maybe not.  Now that I double check, reverting this change
> > didn't seem to fix it.  It's between 20218 and 20238.
>
> Do you see something like this:
>
> Unhandled exception
> ExceptionCode:    c0000005
> Faulting Address:       2c
> Address:            41028a   H:\mingw\mingw32\bin\as.exe
> CS:EIP 1b:41028a
> DS 23 ES 23 FS 3b GS 0
> EAX: 0000002c   EBX: 0000002c   ECX: 00000000
> EDX: 00010001   EBP: 006cfed8   ESI: 007e20e1   ESP: 006cfec0
> EDI: 007e21a8   EFLAGS: 00010206
> Frames:
>      400000+35fd       H:\mingw\mingw32\bin\as.exe
>      400000+1092       H:\mingw\mingw32\bin\as.exe
>      400000+1133       H:\mingw\mingw32\bin\as.exe
>    7c800000+1b202      G:\ReactOS\system32\KERNEL32.dll
> Hartmut
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

WD
--
<Russell> argh
<Russell> iterator shenanigans :/

[Sebastian Gasiorek]

well, you can revert this patch if you want. I'm using mingw and it works
without problem. :/

2005/12/18, WaxDragon [e-mail]:
> Well, I was seeing NTDLL, then a bunch of mingw32-make calls.  It was
> a usermode exception.  Doing some more testing, it is 20238 that is
> causing the problem.
>
> On 12/18/05, Hartmut Birr < [e-mail]> wrote:
> > WaxDragon wrote:
> > > Well, maybe not.  Now that I double check, reverting this change
> > > didn't seem to fix it.  It's between 20218 and 20238.
> >
> > Do you see something like this:
> >
> > Unhandled exception
> > ExceptionCode:    c0000005
> > Faulting Address:       2c
> > Address:            41028a   H:\mingw\mingw32\bin\as.exe
> > CS:EIP 1b:41028a
> > DS 23 ES 23 FS 3b GS 0
> > EAX: 0000002c   EBX: 0000002c   ECX: 00000000
> > EDX: 00010001   EBP: 006cfed8   ESI: 007e20e1   ESP: 006cfec0
> > EDI: 007e21a8   EFLAGS: 00010206
> > Frames:
> >      400000+35fd       H:\mingw\mingw32\bin\as.exe
> >      400000+1092       H:\mingw\mingw32\bin\as.exe
> >      400000+1133       H:\mingw\mingw32\bin\as.exe
> >    7c800000+1b202      G:\ReactOS\system32\KERNEL32.dll
> > Hartmut
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
> WD
>
> <Russell> argh
> <Russell> iterator shenanigans :/
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[WaxDragon]

You are using mingw under ReactOS?  I'm not talking about building
ReactOS with mingw, I'm talking about running mingw inside if ReactOS.
 mingw32-make gets a usermode exception after this commit.

On 12/18/05, Sebastian Gasiorek [e-mail] wrote:
> well, you can revert this patch if you want. I'm using mingw and it works
> without problem. :/

WD

--
<Russell> argh
<Russell> iterator shenanigans :/

[Hartmut Birr]

WaxDragon wrote:
> You are using mingw under ReactOS?  I'm not talking about building
> ReactOS with mingw, I'm talking about running mingw inside if ReactOS.
>  mingw32-make gets a usermode exception after this commit.

r20247 does fix the bug.

- Hartmut

[WaxDragon]

Thanks Sebastian and Hartmut for sorting this out. It works now.

On 12/18/05, Hartmut Birr [e-mail] wrote:
> WaxDragon wrote:
> > You are using mingw under ReactOS?  I'm not talking about building
> > ReactOS with mingw, I'm talking about running mingw inside if ReactOS.
> >  mingw32-make gets a usermode exception after this commit.
>
> r20247 does fix the bug.
> Hartmut
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

--
<Russell> argh
<Russell> iterator shenanigans :/

[Sebastian Gasiorek]

It was Harmut job :) I have just showed that there is another bug by fixing
memcpy :)

Regards,
Sebastian

2005/12/19, WaxDragon [e-mail]:
> Thanks Sebastian and Hartmut for sorting this out. It works now.
>
> On 12/18/05, Hartmut Birr [e-mail] wrote:
> > WaxDragon wrote:
> > > You are using mingw under ReactOS?  I'm not talking about building
> > > ReactOS with mingw, I'm talking about running mingw inside if ReactOS.
> > >  mingw32-make gets a usermode exception after this commit.
> >
> > r20247 does fix the bug.
> > Hartmut
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> --
> <Russell> argh
> <Russell> iterator shenanigans :/
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Hartmut Birr]

WaxDragon wrote:
> Well, I was seeing NTDLL, then a bunch of mingw32-make calls.  It was
> a usermode exception.  Doing some more testing, it is 20238 that is
> causing the problem.

If I replace memove from the string library by the c-function, I don't
see the problem.

- Hartmut