Hi all, Can anyone see the problem with this picture? Every time I move the window, it looks like back behind the window, it gets redrawn. Thanks, James
I have seen this exact problem. I was getting around to filing a bug on it. ;0)
On 1/16/06, James Tabor jimtabor@adsl-64-217-116-74.dsl.hstntx.swbell.net wrote:
Hi all, Can anyone see the problem with this picture? Every time I move the window, it looks like back behind the window, it gets redrawn. Thanks, James
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
-- <Alex_Ionescu> it's like saying let's rename Ke to Kernel because people think it's Ketchup
Hi All,
I think the problem is caused by a bug in NtUserPaintDesktop in /trunk/reactos/subsys/win32k/ntuser/desktop.c
The NtGdiStrechBlt on line 1277 uses the clipping box (Rect) to determin the destination with and hight of the background, but no actual clipping is preformed. A quick fix (hack?) for the problem would be changing the "Rect.right" to "sz.cx" and "Recht.bottom" to "sz.cy". This would update the entire desktop background on every request (just like the Tile and Centre moduses do).
(I don't have a build environment set-up, so i can't test this suggested fix, sorry)
Regards,
Sebastiaan
-----Original Message----- From: ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org]On Behalf Of WaxDragon Sent: Monday, January 16, 2006 2:39 PM To: ReactOS Development List Subject: Re: [ros-dev] Strange Stretch Problem
I have seen this exact problem. I was getting around to filing a bug on it. ;0)
On 1/16/06, James Tabor jimtabor@adsl-64-217-116-74.dsl.hstntx.swbell.net wrote:
Hi all, Can anyone see the problem with this picture? Every time I move
the window,
it looks like back behind the window, it gets redrawn. Thanks, James
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
-- <Alex_Ionescu> it's like saying let's rename Ke to Kernel because people think it's Ketchup
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Hi!
I've set up a build environment, and tested my suggested fix. I had to add a check for a vaild clipping region to get it to work, but this patch fixes the problem:
Index: desktop.c =================================================================== --- desktop.c (revision 20928) +++ desktop.c (working copy) @@ -1274,11 +1274,12 @@
if (WinSta->WallpaperMode == wmStretch) { - NtGdiStretchBlt(hDC, - x, - y, - Rect.right, - Rect.bottom, + if(Rect.right && Rect.bottom) + NtGdiStretchBlt(hDC, + x, + y, + sz.cx, + sz.cy, hWallpaperDC, 0, 0,
Regards,
Sebastiaan
-----Original Message----- From: ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org]On Behalf Of Sebastiaan Roodenburg Sent: Monday, January 16, 2006 3:25 PM To: ReactOS Development List Subject: RE: [ros-dev] Strange Stretch Problem
Hi All,
I think the problem is caused by a bug in NtUserPaintDesktop in /trunk/reactos/subsys/win32k/ntuser/desktop.c
The NtGdiStrechBlt on line 1277 uses the clipping box (Rect) to determin the destination with and hight of the background, but no actual clipping is preformed. A quick fix (hack?) for the problem would be changing the "Rect.right" to "sz.cx" and "Recht.bottom" to "sz.cy". This would update the entire desktop background on every request (just like the Tile and Centre moduses do).
(I don't have a build environment set-up, so i can't test this suggested fix, sorry)
Regards,
Sebastiaan
-----Original Message----- From: ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org]On Behalf Of WaxDragon Sent: Monday, January 16, 2006 2:39 PM To: ReactOS Development List Subject: Re: [ros-dev] Strange Stretch Problem
I have seen this exact problem. I was getting around to filing a bug on it. ;0)
On 1/16/06, James Tabor jimtabor@adsl-64-217-116-74.dsl.hstntx.swbell.net wrote:
Hi all, Can anyone see the problem with this picture? Every time I move
the window,
it looks like back behind the window, it gets redrawn. Thanks, James
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
-- <Alex_Ionescu> it's like saying let's rename Ke to Kernel because people think it's Ketchup
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Hi! I just tested your patch and it works okay! I'll wait for the rest before I commit your patch!
Good Job! James
Sebastiaan Roodenburg wrote:
Hi!
I've set up a build environment, and tested my suggested fix. I had to add a check for a vaild clipping region to get it to work, but this patch fixes the problem:
Index: desktop.c
--- desktop.c (revision 20928) +++ desktop.c (working copy) @@ -1274,11 +1274,12 @@
if (WinSta->WallpaperMode == wmStretch) {
NtGdiStretchBlt(hDC,x,y,Rect.right,Rect.bottom,
if(Rect.right && Rect.bottom)NtGdiStretchBlt(hDC,x,y,sz.cx,sz.cy, hWallpaperDC, 0, 0,Regards,
Sebastiaan
hard to tell maybe rop4 problem again for strechblt ?? or some other bugs
----- Original Message ----- From: "James Tabor" jimtabor@adsl-64-217-116-74.dsl.hstntx.swbell.net To: "ReactOS Development List" ros-dev@reactos.org Sent: den 16 January 2006 06:24 Subject: [ros-dev] Strange Stretch Problem
Hi all, Can anyone see the problem with this picture? Every time I move the
window,
it looks like back behind the window, it gets redrawn. Thanks, James
---------------------------------------------------------------------------- ----
---------------------------------------------------------------------------- ----
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Magnus Olsen wrote:
hard to tell maybe rop4 problem again for strechblt ?? or some other bugs
----- Original Message ----- From: "James Tabor" jimtabor@adsl-64-217-116-74.dsl.hstntx.swbell.net To: "ReactOS Development List" ros-dev@reactos.org Sent: den 16 January 2006 06:24 Subject: [ros-dev] Strange Stretch Problem
Hi all, Can anyone see the problem with this picture? Every time I move the
window,
it looks like back behind the window, it gets redrawn. Thanks, James
Sorry to say~ This problem has been with us since wallpaper was implemented with stretch. Even before GreatLords patches. James
We never have suport rop4 for strechblt the first version of strechblt does ignonre rop4 case. same with the new code.
I am working on a rop4 version of strechblt, But do not know when I have time finish it. same with some other patch I am working on.
----- Original Message ----- From: "James Tabor" jimtabor@adsl-64-217-116-74.dsl.hstntx.swbell.net To: "ReactOS Development List" ros-dev@reactos.org Sent: den 16 January 2006 18:14 Subject: Re: [ros-dev] Strange Stretch Problem
Magnus Olsen wrote:
hard to tell maybe rop4 problem again for strechblt ?? or some other bugs
----- Original Message ----- From: "James Tabor" jimtabor@adsl-64-217-116-74.dsl.hstntx.swbell.net To: "ReactOS Development List" ros-dev@reactos.org Sent: den 16 January 2006 06:24 Subject: [ros-dev] Strange Stretch Problem
Hi all, Can anyone see the problem with this picture? Every time I move the
window,
it looks like back behind the window, it gets redrawn. Thanks, James
Sorry to say~ This problem has been with us since wallpaper was
implemented
with stretch. Even before GreatLords patches. James _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev