Re: [ros-dev] [ros-diffs] [dquintana] 65415: [SHELL32] * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems th...

[Thomas Faber]

On 2014-11-15 13:34, [e-mail] wrote:
> [SHELL32]
> Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems that the shortcuts are all created in their rightful place. If anyone is able to boot, feel free to test.
>
> Modified:
>      branches/shell-experiments/dll/win32/shell32/wine/shellpath.c

So which is it; to Wine or not to Wine? If we need to fork this then
let's put it in another file? Or at least #ifdef __REACTOS__?

[David Quintana (gigaherz)]

I was on my phone and it replied to the wrong email (personal instead of
mailing list), so I'll take this chance to expand the reply adding a little
more detail.

The code appears to work as far as I can tell, but I need to check the
existing tests for it, and possibly add new ones. Then I think it should be
ok to "port" it over to wine (by which I mean ensure the code works with
wine and still passes all the tests there). Although I have no idea how to
add a new library dependency on the wine side, so in that case I'll need
someone to help ;P

On 16 November 2014 21:58, Thomas Faber [e-mail] wrote:
> On 2014-11-15 13:34, [e-mail] wrote:
> > [SHELL32]
> > Commit the folder location fixes. They are mostly untested due to being
> >
> > unable to boot to desktop, but looking at the contents of the HDD after
> > syssetup runs seems that the shortcuts are all created in their rightful
> > place. If anyone is able to boot, feel free to test.
> >
> > Modified:
> >      branches/shell-experiments/dll/win32/shell32/wine/shellpath.c
>
> So which is it; to Wine or not to Wine? If we need to fork this then
> let's put it in another file? Or at least #ifdef __REACTOS__?
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Giannis Adamopoulos]

There is no definite answer here. Getting wine's code revealed a hack in syssetup so that's a step forward. After fixing this, it was proven that this function is still not correct enough so we decided to fix it properly. That's why David wrote a ton of tests for it.

ReactOS Development List [e-mail] wrote on Sun, November 16th, 2014, 9:58 PM:
> On 2014-11-15 13:34, [e-mail] wrote:
> > [SHELL32]
> > Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems that the shortcuts are all created in their rightful place. If anyone is able to boot, feel free to test.
> >
> > Modified:
> >      branches/shell-experiments/dll/win32/shell32/wine/shellpath.c
>
> So which is it; to Wine or not to Wine? If we need to fork this then
> let's put it in another file? Or at least #ifdef __REACTOS__?
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev