Hmm, this is not 64 bit safe. Also I don't understand the modification. It doesn't look right. libtiff uses this differently: http://tiff.sourcearchive.com/documentation/4.0.0~beta4/fax2tiff_8c-source.h...
#if defined(_WIN32) && defined(USE_WIN32_FILEIO) TIFFSetClientdata(faxTIFF, (thandle_t)_get_osfhandle(fileno(in))); #else TIFFSetClientdata(faxTIFF, (thandle_t)fileno(in)); #endif
And we don't even seem to use that function at all. Can anyone explain this?
Am 04.08.2012 20:19, schrieb tfaber@svn.reactos.org:
Author: tfaber Date: Sat Aug 4 18:19:19 2012 New Revision: 57044
URL: http://svn.reactos.org/svn/reactos?rev=57044&view=rev Log: [LIBTIFF]
- Fix a warning
Modified: trunk/reactos/dll/3rdparty/libtiff/rosdiff.patch trunk/reactos/dll/3rdparty/libtiff/tif_open.c
Modified: trunk/reactos/dll/3rdparty/libtiff/rosdiff.patch URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libtiff/rosdif... ============================================================================== --- trunk/reactos/dll/3rdparty/libtiff/rosdiff.patch [iso-8859-1] (original) +++ trunk/reactos/dll/3rdparty/libtiff/rosdiff.patch [iso-8859-1] Sat Aug 4 18:19:19 2012 @@ -7,7 +7,7 @@ { thandle_t m = tif->tif_clientdata; +#ifdef USE_WIN32_FILEIO -+ newvalue = (thandle_t) _get_osfhandle(newvalue); ++ newvalue = (thandle_t)_get_osfhandle((int)newvalue); +#endif /* USE_WIN32_FILEIO */ tif->tif_clientdata = newvalue; return m;
Modified: trunk/reactos/dll/3rdparty/libtiff/tif_open.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libtiff/tif_op... ============================================================================== --- trunk/reactos/dll/3rdparty/libtiff/tif_open.c [iso-8859-1] (original) +++ trunk/reactos/dll/3rdparty/libtiff/tif_open.c [iso-8859-1] Sat Aug 4 18:19:19 2012 @@ -517,7 +517,7 @@ { thandle_t m = tif->tif_clientdata; #ifdef USE_WIN32_FILEIO
- newvalue = (thandle_t) _get_osfhandle(newvalue);
- newvalue = (thandle_t)_get_osfhandle((int)newvalue); #endif /* USE_WIN32_FILEIO */ tif->tif_clientdata = newvalue; return m;