Re: [ros-dev] [ros-diffs] [hbelusca] 62267: [KERNEL32] Revert r62264. Reason: all APIs set the last error when a CSR* call doesn't return STATUS_SUCCESS. If some winetests fail because of this, this is because we do not cor...

[Aleksey Bragin]

Well, it would make sense to talk to Christoph first. It's not THAT 
obvious where the real bug is, and he might have been willing to try to 
find it and fix.

Regards,
Aleksey Bragin


On 21.02.2014 0:17, hbelusca(a)svn.reactos.org wrote:
>   Author: hbelusca
>  Date: Thu Feb 20 20:17:53 2014
>  New Revision: 62267
>
>  URL: http://svn.reactos.org/svn/reactos?rev=62267&view=rev
>  Log:
>  [KERNEL32]
>  Revert r62264.
>  Reason: all APIs set the last error when a CSR* call doesn't return STATUS_SUCCESS.
> If some winetests fail because of this, this is because we do not correctly do what's
> needed here (normally the TRUE or FALSE value is returned by the console server, and is
> not retrieved by a success or failure of a CSR call contrary to what's done here).
>
>  Modified:
>       trunk/reactos/dll/win32/kernel32/client/console/console.c
>
>  Modified: trunk/reactos/dll/win32/kernel32/client/console/console.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…
>  ==============================================================================
>  --- trunk/reactos/dll/win32/kernel32/client/console/console.c	[iso-8859-1] (original)
>  +++ trunk/reactos/dll/win32/kernel32/client/console/console.c	[iso-8859-1] Thu Feb 20
> 20:17:53 2014
>  @@ -796,6 +796,7 @@
>                                     sizeof(CONSOLE_VERIFYHANDLE));
>        if (!NT_SUCCESS(Status))
>        {
>  +        BaseSetLastNTError(Status);
>            return FALSE;
>        }
>    
>
>