Re: [ros-dev] [ros-diffs] [janderwald] 55447: [DISK_NEW] - Fix compilation of new disk driver - Patch by Alex Ionescu

[Jérôme Gardou]

Le 06/02/2012 07:50, [e-mail] a écrit :
> +if(ARCH MATCHES i386)
> add_target_compile_flags(disk "-mrtd -fno-builtin -Wno-unused-variable -Wno-pointer-sign")
>
> +endif()

Hey!

Those look very GCC centric. The corresponding flag for MSVC to -mrtd 
would be /Gz. As for other flags, I'm unsure of what -fno-builtin would 
correspond to, and others are only for warnings.

Cheers.
Jérôme.

[Alex Ionescu]

All of these are only for GCC because MSVC already compiles this correctly.

On 2012-02-06, at 10:07 AM, Jérôme Gardou wrote:
> Le 06/02/2012 07:50, [e-mail] a écrit :
> > +if(ARCH MATCHES i386)
> > add_target_compile_flags(disk "-mrtd -fno-builtin -Wno-unused-variable -Wno-pointer-sign")
> >
> > +endif()
>
> Hey!
>
> Those look very GCC centric. The corresponding flag for MSVC to -mrtd would be /Gz. As for other flags, I'm unsure of what -fno-builtin would correspond to, and others are only for warnings.
>
> Cheers.
> Jérôme.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Jérôme Gardou]

Le 06/02/2012 19:58, Alex Ionescu a écrit :
> All of these are only for GCC because MSVC already compiles this correctly.
>
> On 2012-02-06, at 10:07 AM, Jérôme Gardou wrote:
> > Le 06/02/2012 07:50, [e-mail] a écrit :
> > > +if(ARCH MATCHES i386)
> > > add_target_compile_flags(disk "-mrtd -fno-builtin -Wno-unused-variable -Wno-pointer-sign")
> > >
> > > +endif()
> >
> > Hey!
> >
> > Those look very GCC centric. The corresponding flag for MSVC to -mrtd would be /Gz. As for other flags, I'm unsure of what -fno-builtin would correspond to, and others are only for warnings.
> >
> > Cheers.
> > Jérôme.
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

Are you sure that /Gz is default with cl.exe ? Anyway, those flags 
should be wrapped with if (NOT MSVC) condition.