Re: [ros-dev] [ros-diffs] [gedmurphy] 72594: [FLTMGR] - Implement FltLoadFilter and stub FltUnloadFilter - Register contexts if the caller requests (coming later) - Stubpliment FltStartFiltering

[Thomas Faber]

On 2016-09-06 18:47, [e-mail] wrote:
> @@ -116,12 +150,21 @@
>      InitializeListHead(&Filter->PortList.mList);
>      Filter->PortList.mCount = 0;
> /* We got this far, assume success from here */
> Status = STATUS_SUCCESS;
> /* Check if the caller requested any context data */
>    if (Registration->ContextRegistration)
>    {
>    // register the context information
> }
>    /* Register the contexts for this filter */
>    Status = FltpRegisterContexts(Filter, Registration->ContextRegistration);
>    if (NT_SUCCESS(Status))

I think you mean !NT_SUCCESS?
>    {
>        goto Quit;
>    }
> }
> /* Check if the caller is registering any callbacks */
> if (Registration->OperationRegistration)
> {
>     /* The callback data comes after the fixed struct */
>
> @@ -162,7 +205,7 @@
>      // - More stuff??
>      //
>
> -//Quit:
> +Quit:
>      if (!NT_SUCCESS(Status))
>      {
>          // Add cleanup for context resources