Re: [ros-svn] [frik85] 14355: Remove all hardcode english phrases from the source code and add the phrases to the resource file.

[James Tabor]

[e-mail] wrote:
> Remove all hardcode english phrases from the source code and add the phrases to the resource file.
>
> Updated files:
> trunk/reactos/subsys/system/taskmgr/De.rc
> trunk/reactos/subsys/system/taskmgr/En.rc
> trunk/reactos/subsys/system/taskmgr/affinity.c
> trunk/reactos/subsys/system/taskmgr/applpage.c
> trunk/reactos/subsys/system/taskmgr/column.c
> trunk/reactos/subsys/system/taskmgr/debug.c
> trunk/reactos/subsys/system/taskmgr/endproc.c
> trunk/reactos/subsys/system/taskmgr/priority.c
> trunk/reactos/subsys/system/taskmgr/resource.h
> trunk/reactos/subsys/system/taskmgr/run.c
> trunk/reactos/subsys/system/taskmgr/taskmgr.c
> trunk/reactos/subsys/system/taskmgr/trayicon.c

Hi,
The tabs list only ones and the process list is all zero's. The
columns tags in the process list have no data at all. Everything
else is okay.
James

[Hartmut Birr]

James Tabor wrote:
> Hi,
> The tabs list only ones and the process list is all zero's. The
> columns tags in the process list have no data at all. Everything
> else is okay.
> James

Try make clean and build it again. Dependency tracking doesn't work
properly for resource files.

- Hartmut

[James Tabor]

Hi Hartmut!
Hartmut Birr wrote:
> James Tabor wrote:
> > Hi,
> > The tabs list only ones and the process list is all zero's. The
> > columns tags in the process list have no data at all. Everything
> > else is okay.
> > James
>
> Try make clean and build it again. Dependency tracking doesn't work
> properly for resource files.
> Hartmut

DOH!

Yes, that did fix it!
Thanks,
James

[Klemens Friedl]

> James Tabor wrote:
> The tabs list only ones and the process list is all zero's. The
> columns tags in the process list have no data at all. Everything
> else is okay.

I tested the taskmgr again (in WinXP and ReactOS 0.3 SVN (latest revision)).
The taskmgr works fine!

Screenshot: http://home.pages.at/frik85/temp/taskmgr_01.png

Maybe you have time and can try it again (hint: don't forget "make clean").
If you still have problems, please send me a screenshot; thanks.

Klemens Friedl
-- 
Sparen beginnt mit GMX DSL: http://www.gmx.net/de/go/dsl

[James Tabor]

Hello!

I hear an ECHO!

8^D
James