header hack.... eeh workaround ;)

[Timo Kreuzer]

Hi,

I's like to suggest a workaround to the problem that we have to deal
with both RECT and RECTL structures in win32k and as they
are incompatible need to typecast in a lot of places.

RECTL is what the DDI interface uses (almost) exclusively. While the
NtGdi Interface and a lot of User structures also use RECT.
Both structures are equal, but not compatible when it comes to assigning
one to another, So we need to do all these nasty typecasts.

My suggestion is adding some defines after the inclusion of windef.h:
#define RECT RECTL
#define PRECT PRECTL
#define LPRECT LPRECTL
#define LPCRECT LPCRECTL

same for POINT and POINTL

I'd like to hear your opinion on that.

Thanks,
Timo

[Ged]

As long as you keep it out of the public headers and define it locally I
don't see a problem.

Ged

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Timo Kreuzer
Sent: 17 March 2009 22:50
To: ReactOS Development List
Subject: [ros-dev] header hack.... eeh workaround ;)

Hi,

I's like to suggest a workaround to the problem that we have to deal
with both RECT and RECTL structures in win32k and as they
are incompatible need to typecast in a lot of places.

RECTL is what the DDI interface uses (almost) exclusively. While the
NtGdi Interface and a lot of User structures also use RECT.
Both structures are equal, but not compatible when it comes to assigning
one to another, So we need to do all these nasty typecasts.

My suggestion is adding some defines after the inclusion of windef.h:
#define RECT RECTL
#define PRECT PRECTL
#define LPRECT LPRECTL
#define LPCRECT LPCRECTL

same for POINT and POINTL

I'd like to hear your opinion on that.

Thanks,
Timo

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Timo Kreuzer]

Yes, it was meant for win32k/pch.h only

Ged wrote:
> As long as you keep it out of the public headers and define it locally I
> don't see a problem.
>
> Ged