Before this change, the reactos build seems to want to put hal.a in the root for me (which of course my user doesn't own). Should I commit this? Also, why was this changed?
Index: tools/helper.mk =================================================================== RCS file: /CVS/ReactOS/reactos/tools/helper.mk,v retrieving revision 1.89 diff -u -r1.89 helper.mk --- tools/helper.mk 20 Oct 2004 20:51:21 -0000 1.89 +++ tools/helper.mk 21 Oct 2004 02:24:43 -0000 @@ -270,7 +270,7 @@ MK_CPPFLAGS := -D__NTHAL__ -I. MK_IMPLIB := yes MK_IMPLIBONLY := no - MK_IMPLIBDEFPATH := + MK_IMPLIBDEFPATH := $(DDK_PATH_LIB) MK_IMPLIB_EXT := .a MK_INSTALLDIR := system32 MK_BOOTCDDIR := .
Yes go ahead and commit this. We now create a static library and link that into the executable. The static library is also linked with the tests into an executable that can be executed to run the tests. With hal.a there was a naming conflict for the make rules.
Casper
-----Original Message----- From: ros-dev-bounces@reactos.com [mailto:ros-dev-bounces@reactos.com] On Behalf Of art yerkes Sent: 21. oktober 2004 05:17 To: ros-dev@reactos.com Subject: [ros-dev] Change in tools/helper.mk
Before this change, the reactos build seems to want to put hal.a in the root for me (which of course my user doesn't own). Should I commit this? Also, why was this changed?
Index: tools/helper.mk
RCS file: /CVS/ReactOS/reactos/tools/helper.mk,v retrieving revision 1.89 diff -u -r1.89 helper.mk --- tools/helper.mk 20 Oct 2004 20:51:21 -0000 1.89 +++ tools/helper.mk 21 Oct 2004 02:24:43 -0000 @@ -270,7 +270,7 @@ MK_CPPFLAGS := -D__NTHAL__ -I. MK_IMPLIB := yes MK_IMPLIBONLY := no
- MK_IMPLIBDEFPATH :=
- MK_IMPLIBDEFPATH := $(DDK_PATH_LIB) MK_IMPLIB_EXT := .a MK_INSTALLDIR := system32 MK_BOOTCDDIR := .
-- Hey, Adam Smith, keep your invisible hands to yourself! _______________________________________________ Ros-dev mailing list Ros-dev@reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
-
art yerkes -
Casper Hornstrup